[FE] 바뀐 포스트 api 의 포맷에 맞게 로직을 수정한다. #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooherin
commented
Oct 11, 2024
frontend/src/apis/checklist.ts
Outdated
| @@ -27,10 +27,18 @@ export const getChecklists = async () => { | |||
| return data.checklists.map(mapObjNullToUndefined); | |||
| }; | |||
|
|
|||
| //TODO: 기존 form | |||
| // export const postChecklist = async (checklist: ChecklistPostForm) => { | |||
There was a problem hiding this comment.
부득이하게 에러 발생시 테스팅을 위해 기존 post 를 추가하였습니다.
healim01
reviewed
Oct 11, 2024
|
디테일 페이지로 이동했을 때 바로 안가져와지는 에러 => 백엔드 에러 확인 후 수정 부탁드렸습니다! 포스트 문제는 없습니다:) |
skiende74
reviewed
Oct 14, 2024
Comment on lines
48
to
51
| checklistActions.reset(); | ||
| selectedOptionActions.reset(); | ||
| resetShowTip(); // 옵션의 팁박스 다시표시 | ||
| navigate(ROUTE_PATH.checklistList); | ||
| }; |
There was a problem hiding this comment.
이 함수의 이름은 resetAndGoHome인데 정작 GoHome로직이 없어졌네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
v1/postChecklist 변경 사항
위처럼 보내는 form 에 대한 변경이 생겨, 이와 관련된 로직을 수정하게 되었습니다.
(1) 우선 lat,log 등 약어로 쓰고 있던 네이밍을 latitude, longitude 로 수정하였습니다.
(2)
roomInfoNonValidatedStore에 주소, 지하철, 위치 등을 저장하는 로직은 유지하되, 필요한위치,주소만 post 할 때 꺼내 사용할 수 있도록getFormValues라는 메서드를 스토어에 추가해 사용하였습니다.아직 post 여부는 확인하지 않았으며, 배포 이후에 확인해보겠습니다!
📢 논의하고 싶은 내용
🎸 기타