[FE] 스토리북의 버그를 고치고, 관련 컴포넌트를 일부 수정한다. #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healim01
reviewed
Oct 8, 2024
There was a problem hiding this comment.
해당 파일들 gitignore 에 경로 수정해서 추가하고 삭제처리행할거 같습니다
healim01
reviewed
Oct 8, 2024
frontend/test-results/.last-run.json
Outdated
healim01
reviewed
Oct 8, 2024
| @@ -6,6 +6,13 @@ import FloatingButton from '@/components/_common/FloatingButton/FloatingButton'; | |||
| const meta: Meta<typeof FloatingButton> = { | |||
| title: 'components/FloatingButton', | |||
| component: FloatingButton, | |||
| decorators: [ | |||
| Story => ( | |||
| <div style={{ width: '300px', height: '200px' }}> | |||
There was a problem hiding this comment.
Suggested change
| <div style={{ width: '300px', height: '200px' }}> | |
| <div style={{ width: '30rem', height: '20rem' }}> |
healim01
reviewed
Oct 8, 2024
| decorators: [ | ||
| Story => ( | ||
| <S.Wrapper> | ||
| <div style={{ width: '80px', height: '80px' }}> |
There was a problem hiding this comment.
Suggested change
| <div style={{ width: '80px', height: '80px' }}> | |
| <div style={{ width: '8rem', height: '8rem' }}> |
|
rem 작업 이후 PR 에서 작업하신다고 해서 이만 머지합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
1. 스토리북에서 작동하지 않았거나, 어색했던 스토리들을 수정.
다음과 같은 컴포넌트들을 수정했습니다. 해당 컴포넌트의 스토리 뿐만 아니라, 필요시 소스 코드를 수정했습니다.
AnswerIcon> none : 생성되도록 컴포넌트 수정QuestionCartList: 밑에 팁이 띄어져 있던 UI 를 수정before
after
OptionButton: svg 코드가 다 노출되는 버그 수정Accordion: 애니메이션 로직 추가CheckBox: 불필요한setIsChecked속성 삭제. 해당 속성은 onClick 과 일치하고, 해당 속성을 빼도 문제가 없는 것을 확인했습니다.FloatingButton: 스토리북에서 잘 뜨지 않았던 문제를 template 안에 렌더하여 해결TipBox: 팁이 닫히면 안보여서, 해당 팁을 다시 여는 버튼 추가. 해당 팁 여는 로직이 로컬스토리지에 있어서 추가했습니다.2. 스토리북에서 rem 적용
스토리북에서 rem이 먹히지 않았던 문제를 다음과 같은 코드를
preview.tsx에 추가하여 해결하였습니다.📢 논의하고 싶은 내용
🎸 기타