[BE] 토큰 확인하는 API를 구현한다. #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-jisong
requested changes
Oct 8, 2024
|
|
||
| public record RefreshTokenCheckResponse(boolean isRefreshTokenExist) { | ||
|
|
||
| public static RefreshTokenCheckResponse from (boolean isRefreshTokenExist) { |
There was a problem hiding this comment.
여기 from 뒤에 공백이 잘못 들어간 것 같아요!
| import java.util.List; | ||
|
|
||
| public interface ChecklistStationRepository extends JpaRepository<ChecklistStation, Long> { | ||
|
|
||
| @Query("SELECT cs FROM ChecklistStation cs " + | ||
| "where cs.checklist = :checklist " + | ||
| "and cs.deleted = false") | ||
| List<ChecklistStation> findByChecklist(Checklist checklist); | ||
| List<ChecklistStation> findByChecklist(@Param("checklist") Checklist checklist); |
There was a problem hiding this comment.
저희 id로 빼기로 했던 것 같아요!
일괄적으로 수정하는 일정이 있으면 따로 수정하지는 않아도 될 것 같지만 수정한 파트이길래 리뷰 남깁니다 👀
There was a problem hiding this comment.
테스트가 깨져서 추가한 부분이여서 제가 바꾸는 것보다 나중에 함께 수정하면 좋을 것 같아요~
shin-jisong
reviewed
Oct 8, 2024
| @@ -71,4 +73,13 @@ public ResponseEntity<Void> reIssueAccessToken(HttpServletRequest httpServletReq | |||
| .header(HttpHeaders.SET_COOKIE, accessTokenCookie.toString()) | |||
| .build(); | |||
| } | |||
|
|
|||
| @GetMapping("/refreshToken/check") | |||
There was a problem hiding this comment.
뒤늦게 발견했는데 API URL에서는 kebab-case 사용해야 될 것 같아요!
tkdgur0906
approved these changes
Oct 9, 2024
| @@ -177,7 +177,7 @@ void reIssueAccessToken() { | |||
| AuthTokenResponse tokenResponse = authService.login(OAUTH_LOGIN_REQUEST); | |||
|
|
|||
| // when & then | |||
| assertThatCode(() -> authService.reIssueAccessToken(tokenResponse.refreshToken())) | |||
| assertThatCode(() -> authService.reissueAccessToken(tokenResponse.refreshToken())) | |||
There was a problem hiding this comment.
이 pr에서 AuthServiceTest에 문장형으로 작성된 DisplayName 수정해도 편할 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
/refreshToken/checkAPI 구현📢 논의하고 싶은 내용
🎸 기타