Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 접근성 개선을 위해 인풋필드의 label/input를 서로 htmlFor, id로 연결한다. #758

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

skiende74
Copy link
Contributor

❗ Issue

✨ 구현한 기능

(접근성) 인풋필드에 label/input 접근성을 연결한다.

label/ input 간 연결시켜주었습니다.
label - input이 1:N인 버튼의 경우엔 fieldset으로 묶고 legend로 처리해주었습니다.

📢 논의하고 싶은 내용

🎸 기타

@skiende74 skiende74 self-assigned this Oct 7, 2024
@skiende74 skiende74 changed the title [FE] (접근성) 인풋필드에 label/input 접근성을 연결한다. [FE] (접근성) 인풋필드의 label/input 접근성을 연결한다. Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

@healim01 healim01 changed the base branch from dev to dev-fe October 7, 2024 08:20
@@ -10,11 +10,19 @@ const MaintenanceFee = () => {
const maintenanceFee = useStore(checklistRoomInfoStore, state => state.rawValue.maintenanceFee);
const errorMessage = useStore(checklistRoomInfoStore, state => state.errorMessage.maintenanceFee);

// 토큰있을때.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 주석은 무엇일까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거하였습니다

Copy link
Contributor

@healim01 healim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다,,~ 접근성 개선 생각보다 할 일이 많네요,,~!

@skiende74 skiende74 changed the title [FE] (접근성) 인풋필드의 label/input 접근성을 연결한다. [FE] 접근성 개선을 위해 인풋필드의 label/input를 서로 htmlFor, id로 연결한다. Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

@ooherin ooherin merged commit c4d3c03 into dev-fe Oct 8, 2024
2 checks passed
@ooherin ooherin deleted the feat/757-input-field-a11y branch October 8, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants