Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset의 폴더 구조를 정리하고 파일 이름을 수정한다. #142

Merged
merged 4 commits into from
Jul 26, 2024
Merged

asset의 폴더 구조를 정리하고 파일 이름을 수정한다. #142

merged 4 commits into from
Jul 26, 2024

Conversation

healim01
Copy link
Contributor

❗ Issue

✨ 구현한 기능

  • 파일 이름 변경 preview -> summary
  • 스타일 수정 (마진, 패딩, width)
  • assets 파일 정리

📢 논의하고 싶은 내용

🎸 기타

@healim01 healim01 self-assigned this Jul 26, 2024
skiende74
skiende74 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@skiende74 skiende74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve 합니다.

frontend/src/pages/NewChecklistPage/NewChecklistInfoTemplate.tsx
width: 96%;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버튼 width 수정 확인했습니다.

@ooherin ooherin changed the title 코드 리팩토링 및 파일 리팩토링을 진행한다. asset의 폴더 구조를 정리하고 파일 이름을 수정한다. Jul 26, 2024
@ooherin ooherin self-requested a review July 26, 2024 05:38
@ooherin
Copy link
Contributor

ooherin commented Jul 26, 2024

크로마틱, 테스트가 꺠져서 수정 부탁드립니다

@github-actions GitHub Actions
Copy link

🚀 storybook: https://669cc4025d9f500bb8c34778-gdcbacykwf.chromatic.com/

@healim01 healim01 merged commit ebb663e into dev-fe Jul 26, 2024
2 checks passed
@healim01 healim01 deleted the fix/141-refactor-for-sprint1 branch July 26, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiende74 skiende74 skiende74 approved these changes

@ooherin ooherin Awaiting requested review from ooherin

Assignees

@healim01 healim01

Labels
🔑 FE 🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@healim01 @ooherin @skiende74