[FE] 회원가입시 예외처리를 하고, 한줄평 글자 1칸초과하는것을 해결한다. #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooherin
reviewed
Dec 8, 2024
| @@ -53,6 +54,10 @@ const SubmitModalWithSummary = ({ | |||
| onError(); | |||
| }; | |||
|
|
|||
| const handleChange = (e: ChangeEvent<HTMLInputElement>) => { | |||
| if (e.target.value.length <= 15) summary.onChange(e); | |||
frontend/src/pages/SignUpPage.tsx
Outdated
| @@ -60,16 +60,11 @@ const SignUpPage = () => { | |||
|
|
|||
| const disabled = !isEmailValidated || !isNameValidated || !isPasswordValidated || !isPasswordConfirmValidated; | |||
|
|
|||
| const mutation = usePostSignUpQuery(); | |||
| if (mutation.isSuccess) navigate(ROUTE_PATH.signIn); | |||
There was a problem hiding this comment.
실패시 postErrorMessage 가 떠서 에러 메세지가 렌더링 되게 해주어야 하는데 (로그인과 회원가입 실패는 toast 를 쓰지 않습니다) 이 로직도 포함시켜야 할 것 같습니다! 이렇게 되면 사용자가 회원가입을 실패한 이유를 알 수 없을 것 같아요..
There was a problem hiding this comment.
에러 시 토스트 떠요
(react-query 디폴트로 onError시 토스트 뜨게 되어서그래요)
There was a problem hiding this comment.
리안과 대화결과
토스트보다는 render로 보여주는 게 좋을거같다고 하여,
방법을찾아보고 적용했습니다.
해결한문제 : 디폴트로 들어간 onError를 특정 mutation에대해서만 해제하기
const client = useQueryClient();
client.setMutationDefaults(['auth', 'sign-up'], { onError: undefined });를 통해 특정쿼리에 대해서만 onError를 해제할수있었습니다.
|
로그인 로직인데 참고하시면 좋을 것 같습니다! const handleSubmit = async () =>
await signIn(
{ email, password },
{
onSuccess: async () => {
const result = await getUserInfo();
init(result.userEmail);
showToast({ message: `${result?.userName}님, 환영합니다.`, type: 'confirm' });
return navigate(ROUTE_PATH.home);
},
onError: error => setPostErrorMessage(error.message), //이부분
},
); |
healim01
approved these changes
Dec 8, 2024
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
healim01
reviewed
Dec 8, 2024
frontend/src/pages/SignUpPage.tsx
Outdated
| @@ -60,16 +60,11 @@ const SignUpPage = () => { | |||
|
|
|||
| const disabled = !isEmailValidated || !isNameValidated || !isPasswordValidated || !isPasswordConfirmValidated; | |||
|
|
|||
| const mutation = usePostSignUpQuery(); | |||
| if (mutation.isSuccess) navigate(ROUTE_PATH.signIn); | |||
frontend/src/pages/SignUpPage.tsx
Outdated
Comment on lines
67
to
68
| await mutation.mutate({ name, email, password }); | ||
| showToast({ message: '회원가입이 완료되었습니다.', type: 'confirm' }); |
There was a problem hiding this comment.
이부분 구조분해 + 쿼리 내부로 로직 넣는건 어떨까요?
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
…ng-ggood into fix/1032-sign-up
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
healim01
reviewed
Dec 8, 2024
|
|
||
| const usePostSignUpQuery = () => { | ||
| const client = useQueryClient(); | ||
| client.setMutationDefaults(['auth', 'sign-up'], { onError: undefined }); |
healim01
approved these changes
Dec 8, 2024
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
skiende74
temporarily deployed
to
frontend-msw
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
회원가입시 예외처리
한줄평 글자 1칸초과하는것을 해결한다.
📢 논의하고 싶은 내용
🎸 기타