-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
테스트 CI 환경을 설정한다 #103
Merged
Merged
테스트 CI 환경을 설정한다 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
우선 test결과는 따로 덧글까지 달게하진않았습니다.
한번의 PR push에 덧글이 두번이나 달리는 것도 애매해서 그렇습니다.
덧글 달 때 : PR에 push될때마다(storybook)
러너 돌아갈 때 : PR에 push (storybook(약1.5분), jest(약10초))
🎸 기타
runner의 의존성 설치동작을 action 서버에 저장하여 캐싱하였습니다.
추후 소스코드 변경이 있을 경우만 storybook 동작하도록 변경 필요
이슈 :
github hosted runner / Free 정책이 월간 2000분이며, 이것을 넘어가면 동작이 정지된다고 합니다.
그래서 의존성설치 캐싱을 적용했고,
storybook의 실행이 1분정도 되는데 이 실행횟수도 조금 줄일수있으면 좋아 보입니다.
테스트코드도 지금은 10초도 안걸리지만, 테스트코드가 추가되면 시간이 늘어날 거라 추후
러너 시간단축 방안이 더 필요합니다.