작성한 체크리스트를 조회하는 API를 구현한다. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: tkdgur0906 <[email protected]>
Co-Authored-By: tkdgur0906 <[email protected]>
Co-Authored-By: tkdgur0906 <[email protected]>
Co-Authored-By: tkdgur0906 <[email protected]>
JINU-CHANG
approved these changes
Jul 25, 2024
| @@ -21,6 +21,7 @@ public ResponseEntity<ExceptionResponse> handleBangggoodException(BangggoodExcep | |||
| .body(response); | |||
| } | |||
|
|
|||
| //TODO 로깅해야함 | |||
There was a problem hiding this comment.
runtimeException.printStackTrace(); 처리해두었습니다.
3차 데모데이 미션이 로깅프레임워크 적용이라 그때 다시 얘기해보면 좋을 것 같아요.
tsulocalize
approved these changes
Jul 25, 2024
Comment on lines
40
to
51
| //TODO 테스트해야 함 | ||
| public boolean isQuestionIn(int questionId) { | ||
| return this.id == findIdByQuestionId(questionId); | ||
| } | ||
|
|
||
| private int findIdByQuestionId(int questionId) { | ||
| return Arrays.stream(Category.values()) | ||
| .filter(category -> category.questionIds.contains(questionId)) | ||
| .mapToInt(category -> category.id) | ||
| .findFirst() | ||
| .orElseThrow(() -> new BangggoodException(ExceptionCode.INVALID_QUESTION)); | ||
|
|
There was a problem hiding this comment.
.anyMatch()로 대체할 수 있지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타