리안 헤일리 리뷰반영

woowacourse-teams · Oct 16, 2024 · 2467e45 · 2467e45
1 parent e93c3e5
commit 2467e45
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 24 deletions.
diff --git a/frontend/src/pages/NewChecklistPage.tsx b/frontend/src/pages/NewChecklistPage.tsx
@@ -1,3 +1,4 @@
+import { useNavigate } from 'react-router-dom';
 import { useStore } from 'zustand';
 
 import Button from '@/components/_common/Button/Button';
@@ -21,6 +22,7 @@ import useChecklistStore from '@/store/useChecklistStore';
 import useSelectedOptionStore from '@/store/useSelectedOptionStore';
 
 const NewChecklistPage = () => {
+  const navigate = useNavigate();
   const { tabs } = useChecklistTabs();
 
   const roomInfoActions = useStore(roomInfoStore, state => state.actions);

diff --git a/frontend/src/store/roomInfoStore.ts b/frontend/src/store/roomInfoStore.ts
@@ -12,7 +12,12 @@ type NumberToString<T> = T extends number | string ? string : T;
 
 type RoomInfoStoreState = Required<Omit<RoomInfo, 'createdAt'>>;
 
-// TODO : API POST때 사용할 Mapper 함수 필요. structure(방구조: 처음에 null)
+/** roomInfo 자료를 모두 담는 스토어입니다.
+ * rawValues: roomInfo 백엔드 스키마에 해당하는 자료를 모두 담을 수 있습니다. (다만 number 타입자료형만은 string으로 저장하고있습니다.)
+ * errorMessage: 기본값은 ''(에러없음) 입니다.
+ *
+ * 현재 구현상으로는 폼과 무관해서 안쓰더라도 errorMessage를 만들어줘야합니다.
+ */
 export const initialRoomInfo = {
   roomName: { rawValue: '', errorMessage: '' },
   deposit: { rawValue: '', errorMessage: '' },
@@ -52,6 +57,10 @@ interface RoomInfoActions {
   getParsedValues: () => RoomInfo;
 }
 
+/**
+ * getParsedValues: store에 저장된 걸 백엔드에 POST하는 등 데이터가 필요할때 사용합니다.
+ * getRawValues: errorMessages말고 rawValues들만을 담은 객체를 반환합니다.
+ */
 export const roomInfoStore = createStore<RoomInfoState & { actions: RoomInfoActions }>()(
   persist(
     (set, get) => ({

diff --git a/frontend/src/types/room.ts b/frontend/src/types/room.ts
@@ -26,27 +26,4 @@ export type RoomInfo = Partial<{
   includedMaintenances: number[]; // 관리비 포함항목
 }>;
 
-// export type RoomInfo0 = {
-//   roomName: string;
-//   deposit: number;
-//   rent: number;
-//   maintenanceFee: number;
-//   contractTerm: number;
-//   floorLevel: string;
-//   floor: number;
-//   station: string;
-//   walkingTime: number;
-//   realEstate: string;
-//   size: number;
-//   structure: string;
-//   occupancyMonth: number;
-//   occupancyPeriod: OccupancyPeriod;
-//   summary: string;
-//   memo: string;
-//   type: string;
-//   // createdAt?: string;
-//   address: string;
-//   buildingName: string;
-//   includedMaintenances: number[]; // 관리비 포함항목
-// };
 export type RoomInfoName = keyof RoomInfo;