-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] 감상 조회시 N+1 문제 해결 #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용하지 않는 trip을 join 하는데 LAZY로 설정하는거에 대해서는 어떻게 생각하시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
검증 방법만 알려주시면 감사하겠습니다!
.leftJoin(post.point).fetchJoin() | ||
.leftJoin(post.point.trip).fetchJoin() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 검증을 어떻게 하셨나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
쿼리 개수를 테스트에서 확인하는 방법을 아직 몰라서 테스트 돌리고 나간 쿼리와 갯수를 확인했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
짱입니다~
📌 관련 이슈
📁 작업 설명
그래서 trip도 fetch join했습니다.=> trip을 사용하지 않아서, Point에서 Trip을 Lazy Loading 하도록 설정했습니다.