[feat] 감상 조회시 다른 유저도 감상을 조회할 수 있도록 변경 (#388) #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greeng00se
requested changes
Sep 20, 2023
There was a problem hiding this comment.
현재 인증 헤더가 없더라도 조회하는 기능으로 이해했어요.
Auth 애너테이션만 제외하는 경우 ArgumentResolver만 요청 flow에서 제외될것 같아요.
따라서 Interceptor에서도 감상 단일 조회에 대해 제외 처리를 해주어야 할 것 같아요.
사실 이 부분은 애너테이션으로 구분할 수 있도록 구현하는 방법도 있는 걸로 알고 있어요. 시간이 촉박하니 데모데이 끝나고 구현해보도록 해요.
다시 보니 인증된 사용자만 감상을 조회할 수 있도록 하셨군요 approve 할게요 아침이라 정신이 없네요 ㅋㅋ
빠르게 반영해주시느라 고생하셨습니다.. 👍
greeng00se
approved these changes
Sep 20, 2023
Combi153
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명
💻 주의사항
@Auth LoginUser loginUser가 남아있습니다.