Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Get 요청 시 body 제거 (#379) #380

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[refactor] Get 요청 시 body 제거 (#379) #380

merged 2 commits into from
Sep 20, 2023

Conversation

Combi153
Copy link
Collaborator

📌 관련 이슈

📁 작업 설명

  • Get 요청 시 body가 아닌 QueryString으로 데이터를 보내도록 변경합니다.
  • Post 전체 조회 변경
  • Trip 전체 조회 변경

@Combi153 Combi153 self-assigned this Sep 20, 2023
@Combi153 Combi153 changed the base branch from main to develop-backend September 20, 2023 03:33
@github-actions
Copy link

Test Results

242 tests   242 ✔️  20s ⏱️
  67 suites      0 💤
  67 files        0 ❌

Results for commit bde72e5.

greeng00se
greeng00se approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@greeng00se greeng00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 깔끔하게 변경해주셨네요!

Jaeyoung22
Jaeyoung22 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@Jaeyoung22 Jaeyoung22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 안드로이드와 논의 후 변경될 수 있겠군요! 일단 어프루브 하겠습니다!

@Combi153 Combi153 merged commit bbc1f58 into develop-backend Sep 20, 2023
3 checks passed
@Combi153 Combi153 deleted the refactor/#379 branch September 26, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung22 Jaeyoung22 Jaeyoung22 approved these changes

@greeng00se greeng00se greeng00se approved these changes

Assignees

@Combi153 Combi153

Labels
Backend refactor 후추🧂
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] Get 요청 시 body 제거
3 participants
@Combi153 @greeng00se @Jaeyoung22