[feat] 여행 전체 조회 기능 추가 (#361) #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[refactor] OAuth API 호출에 해당하는 부분을 트랜잭션에서 제외 (#349)
Combi153
changed the title
greeng00se
requested changes
Sep 18, 2023
Comment on lines
15
to
16
| public QueryDslConfig() { | ||
| } |
There was a problem hiding this comment.
우렁각시가 만들어줬어요 제가 안 만들었어요
Comment on lines
21
to
24
| return tripCustomRepository.findAllByConditions( | ||
| tripQueryConditions, | ||
| tripPaging | ||
| ); |
| import org.springframework.transaction.annotation.Transactional; | ||
|
|
||
| @RequiredArgsConstructor | ||
| @Transactional |
There was a problem hiding this comment.
QueryService의 경우 클래스단에 readOnly를 적용하는건 어떤가요?
| } | ||
|
|
||
| private BooleanExpression yearIn(Set<Integer> years) { | ||
| if (CollectionUtils.isEmpty(years)) { |
There was a problem hiding this comment.
null check를 위해 CollectionUtils를 사용하셨군요 👍
Comment on lines
18
to
28
| @ParameterizedTest | ||
| @ValueSource(ints = {2009, 2024}) | ||
| void 연도가_2010_미만_2023_초과이면_예외를_던진다(int year) { | ||
| // given | ||
| Set<Integer> years = of(year); | ||
|
|
||
| // expect | ||
| assertThatThrownBy(() -> new TripQueryConditions(years, of(), of(), of(), of(), "")) | ||
| .isInstanceOf(TripException.class) | ||
| .hasMessage("유효하지 않은 여행 조회 조건입니다."); | ||
| } |
Comment on lines
33
to
34
| private static final int FIRST_INDEX = 0; | ||
| private final TripRepository tripRepository; |
| private final TripRepository tripRepository; | ||
| private final PointRepository pointRepository; | ||
| private final MemberRepository memberRepository; | ||
| private final TripQueryService tripQueryService; |
There was a problem hiding this comment.
TripService가 TripQueryService를 사용하고 있는데 혹시 어떤 이유로 QueryService를 사용하는지 코멘트 남겨주실 수 있나요?
Comment on lines
6
to
12
| public record TripSearchResponse( | ||
| @Schema(description = "여행 Id", example = "1") | ||
| Long tripId, | ||
|
|
||
| @Schema(description = "여행명", example = "통후추의 여행") | ||
| String name, | ||
|
|
||
| @Schema(description = "이미지 주소", example = "https://tripdraw.site/post-images/cd678ca2-30d5-11ee-be56-0242ac120002.jpg") | ||
| String imageUrl, | ||
|
|
||
| @Schema(description = "경로 이미지 주소", example = "https://tripdraw.site/route-images/cd678ca2-30d5-11ee-be56-0242ac120002.png") | ||
| String routeImageUrl | ||
| String routeImageUrl, | ||
| LocalDateTime startTime, | ||
| LocalDateTime endTime |
There was a problem hiding this comment.
일관성을 위해서 Schema를 추가하는 것도 좋을 것 같습니다.
Comment on lines
+8
to
+15
| public record TripSearchConditions( | ||
| Set<Integer> years, | ||
| Set<Integer> months, | ||
| Set<Integer> daysOfWeek, | ||
| Set<Integer> ageRanges, | ||
| Set<Integer> genders, | ||
| String address | ||
| ) { |
There was a problem hiding this comment.
@Builder
public record TripSearchConditions(
Set<@Range(min = 2010, max = 2023) Integer> years,
Set<@Range(min = 1, max = 12) Integer> months,
Set<@Range(min = 1, max = 7) Integer> daysOfWeek,
Set<@Range(min = 1, max = 10) Integer> ageRanges,
Set<@Range(min = 1, max = 2) Integer> genders,
String address
) {
public TripQueryConditions toTripQueryConditions() {
return new TripQueryConditions(years(), months(), daysOfWeek(), ageRanges(), genders(), address());
}
}
Validation을 이용하는건 어떨까요?
There was a problem hiding this comment.
리오는 아직 적용을 안 했던데, 일단은 두고 추후 함께 적용하겠습니다
|
|
||
| @RequiredArgsConstructor | ||
| @Repository | ||
| public class TripCustomRepositoryImpl implements TripCustomRepository { |
There was a problem hiding this comment.
TripQueryRepository로 변경하고 implements를 제거하는건 어떤가요?
Jaeyoung22
requested changes
Sep 19, 2023
| ) { | ||
|
|
||
| public TripQueryConditions toTripQueryConditions() { | ||
| return new TripQueryConditions(years(), months(), daysOfWeek(), ageRanges(), genders(), address()); |
There was a problem hiding this comment.
TripQueryConditions에도 빌더패턴 적용하면 좋을 것 같아요~
There was a problem hiding this comment.
TripQueryConditions 지우고 TripSearchConditions 만 사용하도록 리팩터링 했습니다!
| public class TripSearchConditionsFixture { | ||
|
|
||
| public static TripSearchConditions emptyTripSearchConditions() { | ||
| return new TripSearchConditions( |
There was a problem hiding this comment.
TripSearchConditions에도 빌더 패턴 적용하면 필요한 프로퍼티만 설정할 수 있어서 테스트 코드가 깔끔해질 것 같아요!
# Conflicts: # backend/src/test/java/dev/tripdraw/auth/domain/RefreshTokenRepositoryTest.java # backend/src/test/java/dev/tripdraw/member/domain/MemberRepositoryTest.java # backend/src/test/java/dev/tripdraw/post/domain/PostRepositoryTest.java # backend/src/test/java/dev/tripdraw/trip/domain/PointRepositoryTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명
Cursor-based Pagination 구현했습니다.
자세한 내용은 아래에서 확인해주세요!
Pagination #374
모든 회원의 감상이 있는 여행을 조회하는 api를 구현했습니다.
개발한 api 여행 조회에 대한 테스트를 작성했습니다.
관련해서 다음과 같은 에러를 마주했습니다.
@Nested build 실패 에러 #375