Refactor/#730 오버드로(over draw) 감소

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/common/views/bottomMenuDialog/BottomDialogMenuItem.kt

@@ -12,9 +12,9 @@ class BottomDialogMenuItem(
 ) : AppCompatTextView(context, attrs, R.style.BottomDialogMenuItemStyle) {
 
     init {
-        val verticalPadding =
-            resources.getDimension(R.dimen.padding_bottommenudialog_menu_item_vertical)
-                .roundToInt()
+        val verticalPadding = resources
+            .getDimension(R.dimen.padding_bottommenudialog_menu_item_vertical)
+            .roundToInt()
         setPadding(0, verticalPadding, 0, verticalPadding)
     }
 }

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/common/views/bottomMenuDialog/BottomMenuDialog.kt

@@ -1,24 +1,21 @@
 package com.emmsale.presentation.common.views.bottomMenuDialog
 
 import android.content.Context
-import android.graphics.Color
-import android.graphics.drawable.ColorDrawable
 import android.os.Bundle
 import android.view.ViewGroup
+import com.emmsale.R
 import com.emmsale.databinding.DialogBottomMenuBinding
 import com.emmsale.presentation.common.views.VerticalDivider
 import com.google.android.material.bottomsheet.BottomSheetDialog
 
-class BottomMenuDialog(context: Context) : BottomSheetDialog(context) {
-
-    private val binding: DialogBottomMenuBinding by lazy {
-        DialogBottomMenuBinding.inflate(layoutInflater)
-    }
+class BottomMenuDialog(
+    context: Context,
+) : BottomSheetDialog(context, R.style.RoundBottomSheetDialogStyle) {
+    private val binding by lazy { DialogBottomMenuBinding.inflate(layoutInflater) }
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(binding.root)
-
         initDialogWindow()
     }
 
@@ -51,7 +48,6 @@ class BottomMenuDialog(context: Context) : BottomSheetDialog(context) {
     }
 
     private fun initDialogWindow() {
-        window?.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
         window?.attributes?.let {
             it.width = ViewGroup.LayoutParams.MATCH_PARENT
             it.height = ViewGroup.LayoutParams.WRAP_CONTENT

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/ClubsAddBottomDialogFragment.kt

@@ -5,6 +5,7 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.activityViewModels
+import com.emmsale.R
 import com.emmsale.databinding.FragmentEditmyprofileClubsAddBottomDialogBinding
 import com.emmsale.presentation.common.views.ActivityTag
 import com.emmsale.presentation.common.views.activityChipOf
@@ -41,6 +42,8 @@ class ClubsAddBottomDialogFragment : BottomSheetDialogFragment() {
         viewModel.fetchAllActivities()
     }
 
+    override fun getTheme(): Int = R.style.RoundBottomSheetDialogStyle
+
     private fun initDataBinding() {
         binding.viewModel = viewModel
         binding.addClubs = ::addClubs

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/EducationsAddBottomDialogFragment.kt

@@ -5,6 +5,7 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.activityViewModels
+import com.emmsale.R
 import com.emmsale.databinding.FragmentEditmyprofileEducationsAddBottomDialogBinding
 import com.emmsale.presentation.common.views.ActivityTag
 import com.emmsale.presentation.common.views.activityChipOf
@@ -40,6 +41,8 @@ class EducationsAddBottomDialogFragment : BottomSheetDialogFragment() {
         viewModel.fetchAllActivities()
     }
 
+    override fun getTheme(): Int = R.style.RoundBottomSheetDialogStyle
+
     private fun initDataBinding() {
         binding.viewModel = viewModel
         binding.addEducations = ::addEducations

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/FieldsAddBottomDialogFragment.kt

@@ -5,6 +5,7 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.activityViewModels
+import com.emmsale.R
 import com.emmsale.databinding.FragmentEditmyprofileFieldsAddBottomDialogBinding
 import com.emmsale.presentation.common.views.ActivityTag
 import com.emmsale.presentation.common.views.activityChipOf
@@ -28,7 +29,6 @@ class FieldsAddBottomDialogFragment : BottomSheetDialogFragment() {
     ): View {
         _binding = FragmentEditmyprofileFieldsAddBottomDialogBinding
             .inflate(layoutInflater, container, false)
-        binding.lifecycleOwner = viewLifecycleOwner
         return binding.root
     }
 
@@ -40,6 +40,8 @@ class FieldsAddBottomDialogFragment : BottomSheetDialogFragment() {
         viewModel.fetchAllActivities()
     }
 
+    override fun getTheme(): Int = R.style.RoundBottomSheetDialogStyle
+
     private fun initDataBinding() {
         binding.viewModel = viewModel
         binding.addFields = ::addFields

android/2023-emmsale/app/src/main/java/com/emmsale/presentation/ui/profile/SendMessageDialog.kt

@@ -1,13 +1,12 @@
 package com.emmsale.presentation.ui.profile
 
-import android.graphics.Color
-import android.graphics.drawable.ColorDrawable
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.DialogFragment
 import androidx.fragment.app.activityViewModels
+import com.emmsale.R
 import com.emmsale.databinding.DialogSendMessageBinding
 
 class SendMessageDialog : DialogFragment() {
@@ -24,17 +23,17 @@ class SendMessageDialog : DialogFragment() {
         savedInstanceState: Bundle?,
     ): View {
         _binding = DialogSendMessageBinding.inflate(inflater, container, false)
-        dialog?.window?.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
         binding.lifecycleOwner = viewLifecycleOwner
         return binding.root
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-
         initDataBinding()
     }
 
+    override fun getTheme(): Int = R.style.RoundBottomSheetDialogStyle
+
     private fun initDataBinding() {
         binding.vm = viewModel
         binding.onSendButtonClick = ::onSendButtonClick

android/2023-emmsale/app/src/main/res/drawable/bg_activity_tag.xml

@@ -2,7 +2,7 @@
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
     <item android:state_checked="false">
         <shape android:shape="rectangle">
-            <solid android:color="@color/white" />
+            <solid android:color="@android:color/transparent" />
             <stroke android:width="1dp" android:color="@color/primary_color" />
             <corners android:bottomLeftRadius="30dp" android:bottomRightRadius="20dp" android:topLeftRadius="20dp" android:topRightRadius="30dp" />
             <padding android:bottom="9.5dp" android:left="25dp" android:right="25dp" android:top="9.5dp" />

android/2023-emmsale/app/src/main/res/drawable/bg_all_transparent.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android">
+    <solid android:color="@android:color/transparent" />
+</shape>

android/2023-emmsale/app/src/main/res/drawable/bg_event_search.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="rectangle">
-    <solid android:color="@color/white" />
+    <solid android:color="@android:color/transparent" />
     <corners android:radius="40dp" />
     <stroke
         android:width="1dp"

android/2023-emmsale/app/src/main/res/drawable/bg_eventsearch_search.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="rectangle">
-    <solid android:color="@color/white" />
+    <solid android:color="@android:color/transparent" />
     <corners android:radius="40dp" />
     <stroke
         android:width="1.5dp"

android/2023-emmsale/app/src/main/res/drawable/bg_messagelist_message_input.xml

@@ -4,5 +4,4 @@
     <stroke
         android:width="1dp"
         android:color="@color/light_gray" />
-    <solid android:color="@color/white" />
 </shape>

android/2023-emmsale/app/src/main/res/drawable/bg_primarynotification_header.xml

@@ -2,7 +2,7 @@
 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">
     <item>
         <shape android:shape="rectangle">
-            <solid android:color="@color/white" />
+            <solid android:color="@android:color/transparent" />
         </shape>
     </item>
 

android/2023-emmsale/app/src/main/res/drawable/bg_profile_activityicon.xml

@@ -1,10 +1,14 @@
 <?xml version="1.0" encoding="utf-8"?>
-<shape xmlns:android="http://schemas.android.com/apk/res/android"
-    android:shape="oval">
-    <solid android:color="@color/primary_color" />
-    <padding
-        android:bottom="9dp"
-        android:left="9dp"
-        android:right="9dp"
-        android:top="9dp" />
-</shape>
+<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
+    <item>
+        <shape android:shape="oval">
+            <solid android:color="@color/primary_color" />
+            <padding
+                android:bottom="9dp"
+                android:left="9dp"
+                android:right="9dp"
+                android:top="9dp" />
+        </shape>
+    </item>
+    <item android:drawable="@drawable/ic_profile_education" />
+</layer-list>

android/2023-emmsale/app/src/main/res/drawable/bg_shadow.xml

@@ -34,7 +34,7 @@
     <!-- Background -->
     <item>
         <shape>
-            <solid android:color="@android:color/white" />
+            <solid android:color="@color/white" />
         </shape>
     </item>
 </layer-list>

android/2023-emmsale/app/src/main/res/drawable/bg_tablayout_indicator.xml

@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-
     <item>
         <shape android:shape="rectangle">
-            <solid android:color="@color/white" />
+            <solid android:color="@android:color/transparent" />
         </shape>
     </item>
+
     <item android:gravity="bottom">
         <shape android:shape="rectangle">
             <solid android:color="@color/unselected_tab_indicator_color" />

android/2023-emmsale/app/src/main/res/layout/activity_child_comments.xml

@@ -26,14 +26,12 @@
     <androidx.constraintlayout.widget.ConstraintLayout
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:background="@color/white"
         tools:context=".presentation.ui.childCommentList.ChildCommentActivity">
 
         <com.google.android.material.appbar.MaterialToolbar
             android:id="@+id/tb_childcomments_toolbar"
             android:layout_width="0dp"
             android:layout_height="?actionBarSize"
-            android:background="@color/white"
             android:keepScreenOn="true"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
@@ -72,7 +70,6 @@
                     android:id="@+id/layout_childcomments_postchildcomment"
                     android:layout_width="0dp"
                     android:layout_height="wrap_content"
-                    android:background="@color/white"
                     android:paddingStart="17dp"
                     android:paddingTop="8dp"
                     android:paddingEnd="17dp"
@@ -97,7 +94,7 @@
                             android:layout_width="0dp"
                             android:layout_height="wrap_content"
                             android:layout_marginStart="1dp"
-                            android:background="@android:color/transparent"
+                            android:background="@null"
                             android:fontFamily="@font/nanum_square_regular"
                             android:hint="@string/childcomments_edit_child_comment_hint"
                             android:importantForAutofill="no"
@@ -134,7 +131,6 @@
                     android:id="@+id/layout_childcomments_comment_update"
                     android:layout_width="0dp"
                     android:layout_height="wrap_content"
-                    android:background="@color/white"
                     android:clickable="@{layoutChildcommentsCommentUpdate.visibility == View.VISIBLE}"
                     android:elevation="5dp"
                     android:paddingTop="8dp"
@@ -211,7 +207,8 @@
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toBottomOf="@id/tb_childcomments_toolbar"
-            bind:viewModel="@{viewModel}" />
+            bind:viewModel="@{viewModel}"
+            tools:visibility="gone" />
 
     </androidx.constraintlayout.widget.ConstraintLayout>
 </layout>

android/2023-emmsale/app/src/main/res/layout/activity_edit_my_profile.xml

@@ -33,7 +33,6 @@
         android:id="@+id/cl_editmyprofile_root"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:background="@color/white"
         tools:context=".presentation.ui.editMyProfile.EditMyProfileActivity">
 
         <com.google.android.material.appbar.MaterialToolbar
@@ -130,7 +129,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginTop="2dp"
-                    android:layout_marginEnd="17dp"
+                    android:layout_marginEnd="16dp"
                     android:contentDescription="@string/editmyprofile_field_add_button"
                     android:onClick="@{() -> showFieldTags.invoke()}"
                     app:layout_constraintEnd_toEndOf="parent"
@@ -144,9 +143,9 @@
                     android:layout_marginTop="30dp"
                     android:layout_marginEnd="17dp"
                     android:contentDescription="@string/editmyprofile_member_image"
+                    android:onClick="@{()->editProfileImage.invoke()}"
                     app:imageUrl="@{viewModel.profile.member.profileImageUrl}"
                     app:isCircle="@{true}"
-                    android:onClick="@{()->editProfileImage.invoke()}"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
                     tools:srcCompat="@tools:sample/avatars" />
@@ -166,11 +165,11 @@
                     android:id="@+id/rv_editmyprofile_fields"
                     android:layout_width="0dp"
                     android:layout_height="wrap_content"
-                    android:layout_marginStart="17dp"
                     android:layout_marginTop="23dp"
-                    android:layout_marginEnd="17dp"
+                    android:clipToPadding="false"
                     android:orientation="horizontal"
                     android:overScrollMode="never"
+                    android:paddingHorizontal="17dp"
                     app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintStart_toStartOf="parent"
@@ -239,8 +238,7 @@
                     android:background="@drawable/bg_profile_activityicon"
                     android:importantForAccessibility="no"
                     app:layout_constraintStart_toStartOf="@+id/tv_editmyprofile_activity_label"
-                    app:layout_constraintTop_toBottomOf="@+id/tv_editmyprofile_choose_activity_message"
-                    app:srcCompat="@drawable/ic_profile_education" />
+                    app:layout_constraintTop_toBottomOf="@+id/tv_editmyprofile_choose_activity_message" />
 
                 <TextView
                     android:id="@+id/tv_editmyprofile_educations_label"
@@ -310,8 +308,7 @@
                     android:background="@drawable/bg_profile_activityicon"
                     android:importantForAccessibility="no"
                     app:layout_constraintStart_toStartOf="@+id/iv_editmyprofile_education_icon"
-                    app:layout_constraintTop_toBottomOf="@+id/tv_editmyprofile_education_add_button"
-                    app:srcCompat="@drawable/ic_profile_education" />
+                    app:layout_constraintTop_toBottomOf="@+id/tv_editmyprofile_education_add_button" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>