Refactor/#720 member model 관련 리팩토링 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 안쓰이는 OpenProfileUrlConfig Activity와 ViewModel 제거 - SettingFragment 와 fragment_setting.xml 에서 OpenProfileUrlConfig관련 로직 제거
…sUiState를 만들어 활동들을 관리하도록 수정
tmdgh1592
requested changes
Oct 16, 2023
Comment on lines
47
to
48
| isShrinkResources = false | ||
| isMinifyEnabled = false |
There was a problem hiding this comment.
이전에 테스트용으로 false로 바꿔주었는데, 다시 true로 바꿔주어야 할 것 같습니다.
...emmsale/app/src/main/java/com/emmsale/data/repository/concretes/DefaultActivityRepository.kt
Outdated
Show resolved
Hide resolved
Comment on lines
29
to
33
| if (result is Success) { | ||
| allActivities = result.data | ||
| return@withContext result | ||
| } else { | ||
| return@withContext result |
There was a problem hiding this comment.
캐싱을 하려면 Mutex를 사용하여 동시성 문제를 해결해줄 필요가 있습니다.
동시성 문제에 취약한 코드는 아니지만 공식문서에서 제공해주는만큼 적용해보면 좋을 듯 합니다.
...3-emmsale/app/src/main/java/com/emmsale/data/repository/concretes/DefaultMemberRepository.kt
Show resolved
Hide resolved
...3-emmsale/app/src/main/java/com/emmsale/data/repository/concretes/DefaultMemberRepository.kt
Show resolved
Hide resolved
...ale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/uiState/ActivitiesUiState.kt
Outdated
Show resolved
Hide resolved
...msale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/uiState/ActivityUiState.kt
Outdated
Show resolved
Hide resolved
.../app/src/main/java/com/emmsale/presentation/ui/editMyProfile/uiState/EditMyProfileUiState.kt
Outdated
Show resolved
Hide resolved
...mmsale/app/src/main/java/com/emmsale/presentation/ui/editMyProfile/EditMyProfileViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/emmsale/presentation/ui/editMyProfile/EducationsAddBottomDialogFragment.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
예상 소요 시간 및 실제 소요 시간
💬리뷰 요구사항(선택)
한번에 리팩토링 하는것은 불가능해 보여요 시간적으로... 점차적으로 리팩토링 해야 할 것 같습니다... 어차피 한번 더 이 코드들을 손 봐야할 것 같아서, 너무 세세한 리뷰는 자제 부탁드립니다.