feat : 낮은 버젼에서도 이미지를 올릴 수 있도록 구현 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki960213
approved these changes
Oct 11, 2023
Comment on lines
+64
to
+67
| return (0 until count).mapNotNull { i -> | ||
| val uri = clipData.getItemAt(i).uri | ||
| getAbsolutePathFromUri(uri) | ||
| } |
There was a problem hiding this comment.
저는 i라고 해도 index라는 것을 바로 알 수 있기 때문에 괜찮습니다! :)
| } | ||
|
|
||
| else -> Unit | ||
| } | ||
| } | ||
|
|
||
| private fun navigateToBack() { |
Comment on lines
430
to
433
| <string name="post_writing_title_warning">제목을 입력해 주세요</string> | ||
| <string name="post_writing_content_warning">내용은 8자 이상이어야 합니다</string> | ||
| <string name="post_writing_image_permission_denied_message">사진 권한이 거부되었습니다.</string> | ||
| <string name="post_writing_max_image_count_warning_message">최대 5장까지만 선택 가능합니다</string> |
There was a problem hiding this comment.
위에 post_writing 묶어 놓은 거랑 같이 두면 좋을 것 같습니다!
tmdgh1592
approved these changes
Oct 11, 2023
Comment on lines
155
to
157
| <service | ||
| android:name="com.google.android.gms.metadata.ModuleDependencies" | ||
| android:enabled="false" |
| } | ||
|
|
||
| // use when build version under 33 | ||
| private val lowVersionAlbumLauncher = |
There was a problem hiding this comment.
lowVersion, highVersion 보다는 어떤 버전 이하에서 사용되는 launcher인지 변수명에 명시해주세요.
그럼 주석없이 사용할 때 명확하게 알아볼 수 있습니다.
+) 프로퍼티는 함수 이전에 배치시켜주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
33.webm
33.webm
예상 소요 시간 및 실제 소요 시간