This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
[BE] feat: 발행 후 발행 url 글 정보 조회 API 응답에 추가 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2023 17:08
# Conflicts: # backend/src/main/java/org/donggle/backend/application/service/blog/PublishService.java
ezzanzzan
approved these changes
Sep 18, 2023
| blogWriting.getBlogTypeValue(), | ||
| blogWriting.getPublishedAt(), | ||
| blogWriting.getTags())) | ||
| .map(PublishedDetailResponse::of) |
There was a problem hiding this comment.
풀어서 넣는것보다 내부에서 값을 저장하는게 더 나을까요 ?
There was a problem hiding this comment.
장단점이 있을것 같습니다만, 뭔가 한눈에 blogWriting이 PublishedDetailResponse로 바꼈구나를 알 수 있는거 같아서 좋은 것 같아요!
HubCreator
approved these changes
Sep 18, 2023
| @@ -34,12 +34,14 @@ public class BlogWriting extends BaseEntity { | |||
| private LocalDateTime publishedAt; | |||
| @ElementCollection | |||
| private List<String> tags; | |||
| private String url; | |||
There was a problem hiding this comment.
수정을할까 했는데,, 아무래도 Publish 쪽과 연관이 되어있어서 충돌이 좀 날꺼 같아 나중에 해야할꺼 같네요!
Comment on lines
+15
to
16
| return new PublishedDetailResponse(blogWriting.getBlogTypeValue(), blogWriting.getPublishedAt(), blogWriting.getTags(), blogWriting.getUrl()); | ||
| } |
echo724
pushed a commit
that referenced
this pull request
Sep 22, 2023
feat: 발행 후 글 조회시 글 정보에 발행 글 url 필드 추가
echo724
pushed a commit
that referenced
this pull request
Oct 6, 2023
feat: 발행 후 글 조회시 글 정보에 발행 글 url 필드 추가
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Issue
✅ Tasks
⏰ Time Difference
📝 Note