Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: infoWindow 디자인을 개선한다 #832

Merged
merged 13 commits into from
Oct 6, 2023
Merged

design: infoWindow 디자인을 개선한다 #832

merged 13 commits into from
Oct 6, 2023

Conversation

feb-dain
Copy link
Collaborator

@feb-dain feb-dain commented Oct 6, 2023 •
edited by github-actions bot
Loading

📄 Summary

기존 임시적으로 두었던 infoWindow 디자인을 개선했습니다!
마커 색깔이 무슨 뜻인지 모르는 사용자들이 많아 마커를 한 번 클릭만 해도 마커 색깔이 무슨 뜻인지 알 수 있도록 했습니다.
그리고 이제 급속, 완속 충전기 별로 사용할 수 있는 충전기가 몇 개인지 알 수 있게 됐습니다👏🏻

image

여전히 높이가 너무 길다는 문제가 있는데 사실

image

이용 제한과 무료 주차 정보를 빼면 바로 해결되는 일이긴 합니다만 😂
이게 꽤 중요한 정보라고 생각해서 최대한 안 빼는 게 좋을 것 같기도 하고... 잘 모르겠습니다!

충전소 이름, 회사명이 실제로 긴 경우가 많아서 바뀐 디자인이 정확히 어떻게 보일지는 prod로 한 번 배포해봐야 확실히 알 것 같습니다!

🕰️ Actual Time of Completion

3시간

🙋🏻 More

close #823

🚀 Storybook

https://storybook.carffe.in/

@feb-dain feb-dain added 🛠️ 리팩터링 개선사항입니다 FE 프론트엔드 관련 이슈입니다 🦜 UI UI 디자인을 수정합니다 labels Oct 6, 2023
@feb-dain feb-dain self-assigned this Oct 6, 2023
@feb-dain feb-dain temporarily deployed to test October 6, 2023 03:53 — with GitHub Actions Inactive
@feb-dain feb-dain temporarily deployed to test October 6, 2023 03:58 — with GitHub Actions Inactive
@feb-dain feb-dain temporarily deployed to test October 6, 2023 04:18 — with GitHub Actions Inactive
@kyw0716 kyw0716 temporarily deployed to test October 6, 2023 04:40 — with GitHub Actions Inactive
kyw0716
kyw0716 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@kyw0716 kyw0716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@feb-dain feb-dain merged commit bab2aaf into develop Oct 6, 2023
4 checks passed
@feb-dain feb-dain deleted the design/823 branch October 6, 2023 04:56
feb-dain added a commit that referenced this pull request Oct 6, 2023
@feb-dain
Revert "design: infoWindow 디자인을 개선한다 (#832)"
03a5753 
This reverts commit bab2aaf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyw0716 kyw0716 kyw0716 approved these changes

@gabrielyoon7 gabrielyoon7 gabrielyoon7 approved these changes

Assignees

@feb-dain feb-dain

Labels
FE 프론트엔드 관련 이슈입니다 🛠️ 리팩터링 개선사항입니다 🦜 UI UI 디자인을 수정합니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StationInfoWindow의 디자인을 개선한다
3 participants
@feb-dain @gabrielyoon7 @kyw0716