입찰 시 이전 사용자에게 알림을 보낼 때 Optional 로직 변경 #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apptie
added
refactor
JJ503
requested changes
Nov 8, 2023
Comment on lines
+54
to
+58
| auction.findLastBidder() | ||
| .ifPresent(previousBidder -> | ||
| publishBidNotificationEvent(auctionImageAbsoluteUrl, auctionAndImageDto, previousBidder)); | ||
|
|
||
| publishBidNotificationEvent(auctionImageAbsoluteUrl, auctionAndImageDto, previousBidder); | ||
|
|
||
| return saveBid.getId(); | ||
| return saveAndUpdateLastBid(bidDto, auction, bidder).getId(); |
There was a problem hiding this comment.
질문
위 로직이라면 알람이 간 뒤 저장을 시키는 것인데, 저장 과정에서 예기치 못한 오류로 실패해 롤백되어도 알람이 가는 것은 괜찮을까요?
There was a problem hiding this comment.
그러네요 그 부분은 놓쳤습니다
순서를 변경하도록 하겠습니다
swonny
approved these changes
Nov 8, 2023
kwonyj1022
requested changes
Nov 8, 2023
Comment on lines
54
to
58
| final Bid saveBid = saveAndUpdateLastBid(bidDto, auction, bidder); | ||
|
|
||
| publishBidNotificationEvent(auctionImageAbsoluteUrl, auctionAndImageDto, previousBidder); | ||
| auction.findLastBidder() | ||
| .ifPresent(previousBidder -> | ||
| publishBidNotificationEvent(auctionImageAbsoluteUrl, auctionAndImageDto, previousBidder)); |
There was a problem hiding this comment.
필수
saveAndUpdateLastBid()를 수행하고 나서 findLastBidder()를 하게 되면 saveAndUpdateLastBid()를 수행해서 lastBidder가 바뀐 뒤에 findLastBidder()가 수행되게 됩니다. 그러면 알림 대상이 이전 입찰자가 아니라 현재 입찰하고 있는 사람이 되기 때문에 findLastBidder()를 하고 나서 saveAndUpadateLastBid()를 해주어야 합니다.
There was a problem hiding this comment.
그러네요 요 부분은 또 놓쳤네요
좀 더 고민을 해보겠습니다
There was a problem hiding this comment.
헐 그러네요 엔초........
왜 저는 이걸 생각 못했을까요..?
엔초 진짜 멋지다..
There was a problem hiding this comment.
제이미의 리뷰 적용 전으로 롤백했습니다
|
일단 닫겠습니다 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 작업 내용 요약
입찰 시 이전 사용자에게 알림을 보낼 때 Optional 로직 변경
🙋🏻 리뷰 시 주의 깊게 확인해야 하는 코드
📎 Issue 번호