신뢰도 0.0과 초기 신뢰도가 구분되도록 하는 기능 추가 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apptie
approved these changes
Oct 19, 2023
| @@ -14,7 +14,7 @@ | |||
| @ToString | |||
| public class Reliability { | |||
|
|
|||
| private static final double INITIAL_RELIABILITY_VALUE = Double.MIN_VALUE; | |||
| private static final double INITIAL_RELIABILITY_VALUE = -999.0d; | |||
There was a problem hiding this comment.
선택
-Double.MAX_VALUE도 고려할 수는 있겠네요
swonny
approved these changes
Oct 19, 2023
|
|
||
| public class ReliabilityProcessor { | ||
|
|
||
| private static final Float EMPTY_RELIABILITY = null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 작업 내용 요약
신뢰도 0.0과 초기 신뢰도가 구분되도록 하는 기능 추가
🙋🏻 리뷰 시 주의 깊게 확인해야 하는 코드
이전에 초기 신뢰도를
Double.MIN_VALUE로 했었는데 이게 음수가 아니었더라구요? 0에 아주 가까운 양수인 소수였습니다.따라서 초기 신뢰도를
-999.0d로 바꾸었습니다.📎 Issue 번호