-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
이미지url에 id 대신 파일 이름을 사용하도록 변경 #717
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f1fff59
refactor: 이미지 상대 url 기반으로 url을 계산하는 메서드 파라미터로 이미지 id 대신 이미지 이름을 받도록 변경
kwonyj1022 0c7b648
refactor: 이미지 절대 url 기반으로 url을 계산하는 메서드 파라미터로 이미지 id 대신 이미지 이름을 받도록 변경
kwonyj1022 1375972
refactor: 경매 조회 시 판매자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 fd9e440
refactor: 입찰 목록 조회 시 입찰자 정보 조회로 인한 n+1 개선
kwonyj1022 05b09e2
refactor: 채팅방 관련 조회 시 참여자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 69a134f
refactor: qna 관련 조회 시 사용자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 a02c1d6
refactor: 신고 관련 조회 시 사용자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 c98c3a7
refactor: 평가 관련 조회 시 사용자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 7ad27b7
refactor: 사용자 정보 조회 시 사용자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 f6c2d4e
refactor: 메시지 알림 시 작성자 프로필 이미지 조회로 인한 n+1 개선
kwonyj1022 5aa95a9
feat: 이미지 이름이 포함된 url로 조회 시 이미지 파일을 반환하는 기능 추가
kwonyj1022 f66f23e
docs: 문서 최신화
kwonyj1022 d56bda4
style: 개행 수정 및 누락된 final 추가
kwonyj1022 0cf6634
ci: 브랜치 최신화
kwonyj1022 e5e8cad
rename: test에 사용되는 fixture 클래스 이름 변경
kwonyj1022 0195e3d
ci: 브랜치 최신화
kwonyj1022 beebe84
ci: 충돌 해결
kwonyj1022 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 3 additions & 2 deletions
5
...end/ddang/src/main/java/com/ddang/ddang/auction/application/dto/CreateInfoAuctionDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
backend/ddang/src/main/java/com/ddang/ddang/chat/application/dto/ReadUserInChatRoomDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
backend/ddang/src/main/java/com/ddang/ddang/image/application/util/ImageIdProcessor.java
This file was deleted.
Oops, something went wrong.
26 changes: 26 additions & 0 deletions
26
...d/ddang/src/main/java/com/ddang/ddang/image/application/util/ImageStoreNameProcessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package com.ddang.ddang.image.application.util; | ||
|
||
import com.ddang.ddang.image.domain.AuctionImage; | ||
import com.ddang.ddang.image.domain.ProfileImage; | ||
|
||
public final class ImageStoreNameProcessor { | ||
|
||
private ImageStoreNameProcessor() { | ||
} | ||
|
||
public static String process(final ProfileImage profileImage) { | ||
if (profileImage == null) { | ||
return null; | ||
} | ||
|
||
return profileImage.getImage().getStoreName(); | ||
} | ||
|
||
public static String process(final AuctionImage auctionImage) { | ||
if (auctionImage == null) { | ||
return null; | ||
} | ||
|
||
return auctionImage.getImage().getStoreName(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,8 +19,6 @@ | |
public class ProfileImage { | ||
|
||
public static final String DEFAULT_PROFILE_IMAGE_STORE_NAME = "default_profile_image.png"; | ||
// TODO: 10/13/23 앞으로 id가 아닌 store name으로 진행하기로 했는데, 임시로 해둡니다. 추후 삭제해주시면 감사하겠습니다. | ||
public static final String DEFAULT_PROFILE_IMAGE_ID = "1"; | ||
Comment on lines
-22
to
-23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 칭찬잊지않고 해주셨군요 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 칭찬훌륭합니다 👍 |
||
|
||
@Id | ||
@GeneratedValue(strategy = GenerationType.IDENTITY) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
칭찬
👍👍👍