Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

프로필 정보 뷰 텍스트 대응 및 탭 레이아웃 백그라운드 속성 수정 #711

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

rhthrhrl0
Copy link
Collaborator

📄 작업 내용 요약

프로필 정보 뷰 텍스트 대응 및 탭 레이아웃 백그라운드 속성 수정

🙋🏻 리뷰 시 주의 깊게 확인해야 하는 코드

없음

📎 Issue 번호

@rhthrhrl0 rhthrhrl0 added android 안드로이드와 관련된 이슈나 PR에 사용 refactor 기존 기능에 변경이 없는 구현 변경 시 labels Oct 18, 2023
@rhthrhrl0 rhthrhrl0 added this to the 최종 데모데이 milestone Oct 18, 2023
@rhthrhrl0 rhthrhrl0 requested review from hyemdooly and ippnsj October 18, 2023 01:18
@rhthrhrl0 rhthrhrl0 self-assigned this Oct 18, 2023
Copy link
Collaborator

@hyemdooly hyemdooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

Copy link
Collaborator

@ippnsj ippnsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~
프로필뷰 닉네임 마진 처리만 기존으로 돌리면 좋을 것 같아요! 👍

Comment on lines 46 to 47
android:layout_marginStart="16dp"
android:layout_marginHorizontal="16dp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 원래대로가 다른 뷰들과의 마진 차이가 없을 것 같아요~!
그래야 가이드라인에 맞춰질 것 같습니다! 😉

@rhthrhrl0 rhthrhrl0 merged commit 55fe89a into develop-an Oct 18, 2023
@rhthrhrl0 rhthrhrl0 deleted the refactor/708 branch October 18, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 안드로이드와 관련된 이슈나 PR에 사용 refactor 기존 기능에 변경이 없는 구현 변경 시
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants