Docker Backend: fully support windows container

[6543]

close #4286
address one bug described in #4274

TODO: actuall testing of:

• normal steps
• services
• plugins

[codecov]

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.64%. Comparing base (ebf9f9c) to head (1854ac5).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/backend/docker/convert_win.go	88.88%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4381      +/-   ##
==========================================
+ Coverage   27.57%   27.64%   +0.06%     
==========================================
  Files         381      382       +1     
  Lines       27923    27952      +29     
==========================================
+ Hits         7700     7726      +26     
- Misses      19538    19540       +2     
- Partials      685      686       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[6543]

 ./dist/woodpecker-agent.exe --backend-engine docker --backend-docker-host "npipe:////./pipe/docker_engine"

[6543]

look's like it works :)

the only thing is i had to modify the clone plugin:

--- a/plugins/plugin-git/Dockerfile.Windows
+++ b/plugins/plugin-git/Dockerfile.Windows
@@ -1,7 +1,7 @@
 # syntax = docker/dockerfile:1
 # escape=`

-FROM mcr.microsoft.com/windows/servercore:ltsc2022
+FROM mcr.microsoft.com/windows/servercore:1809

 # Busybox Unicode https://github.com/rmyorston/busybox-w32

[6543]

so yes woodpecker itselve wont support windows container fully ...
... mostly depending on:

• Add Azure Autoscaler support autoscaler#202
• Ignore agents that are not sufficient for pending workload autoscaler#133 (we need to autoscale a windows host with docker configured to host windows container ...)

[6543]

PS: I still have no idea why some things work and some are incompatible :/

[6543]

my test config:
.woodpecker/check.yaml:

labels:
  backend: docker
  platform: windows/amd64

skip_clone: true

depends_on:
    - echo

steps:
    check_echo:
        image: mcr.microsoft.com/windows/servercore:1809
        commands:
            - echo some checks
            - sleep 2s

.woodpecker/echo.yaml:

labels:
  backend: docker
  platform: windows/amd64

when:
  - event: pull_request
  - event: [push, deployment]
    branch:
      - ${CI_REPO_DEFAULT_BRANCH}

clone:
  clone:
    image: woodpecker-windows-git

steps:
    createFile:
        image: mcr.microsoft.com/windows/servercore:1809
        commands:
            - echo FROM alpine:edge >> Dockerfile
            - echo RUN apk update >> Dockerfile

    echo:
        image: mcr.microsoft.com/windows/servercore:1809
        commands:
            - echo buildZ
            - sleep 10s
            - ls
    depl:
        image: bash
        commands: echo deploy
        when:
            - event: deployment
              branch: ${CI_REPO_DEFAULT_BRANCH}

[6543]

[6543]

@cduchenoy ☝️ ...?

[cduchenoy]

Hi,

It's excellent!

On Windows, we must take the tag which corresponds to the kernel version

see https://hub.docker.com/r/microsoft/windows-servercore

So I think I should check :)

• 1809 => Windows server 2016 base
• ltsc2019 => Windows server 2019 base
• ltsc2022 => Windows server 2022 base
• ltsc2025 => Windows server 2025 base

did you also test the agent build?

https://github.com/GECO-IT/woodpecker-windows/blob/main/agent/backend-docker/Dockerfile.Windows

[cduchenoy]

For test a service image, you can use as a base: https://github.com/GECO-IT/woodpecker-windows/blob/main/base/windows-base/Dockerfile.base-chocolatey.Windows

Base image are in docker-hub: https://hub.docker.com/r/gecoit84/woodpecker-windows-base-chocolatey

and add:

choco install mysql

I haven't tried so I don't know if it launches the service correctly

[6543]

did you also test the agent build?

no as I only wana test if the engine works ... so the deployment of the agent should not alter the test ...

[6543]

For test a service

ah nice ... will do so

[6543]

labels:
  backend: docker
  platform: windows/amd64

skip_clone: true

steps:
    create:
        image: mcr.microsoft.com/windows/servercore:1809
        commands:
            - echo some checks > NEW
            - sleep 2s

    curl:
        image: a6543/woodpecker-windows-base-chocolatey:latest
        commands:
            - choco install -y curl
            - curl.exe -I http://caddy:80
            - curl.exe http://caddy:80/NEW

services:
    caddy:
        image: a6543/woodpecker-windows-caddy-static:latest
        ports:
            - 80

services work just fine ...

[pat-s]

no clue about windows but lgtm WRT to the diff.

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-4381.surge.sh

[6543]

-> #4464