Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt to default colour channel keybinds #562

Open
wants to merge 1 commit into
base: dynamicimage
Choose a base branch
from

Conversation

Stoppedpuma
Copy link
Collaborator

PRing into dynamicimage instead of pushing since this wasn't discussed with anyone. Part of solving the confusion at #561.

Changes the default keybind for colour channels to require alt to reduce the chances of accidentally changing channels, but still being able to change channels with one hand.

@woelper
Copy link
Owner

woelper commented Dec 26, 2024

I am not sure to what this would map on OSX since there is no alt, maybe it is mapped to option? I am concerned that this makes it hard for some folks to access the shortcut.

@Stoppedpuma
Copy link
Collaborator Author

Stoppedpuma commented Dec 26, 2024

I would assume option would be alt as that's what I've always found the equivalent to be? We could always do shift or just not change anything at all, I went with alt originally since people are less likely to set an equivalent keybinding to those keys combined with alt.

Upon further research it seems some mac keyboards actually label the option keys with alt, it seems to be more common in US layouts.

One more thing which is probably worth considering is if this would be handled correctly with reimplementing keybinds the way you wanted to (notes of discussion can be found at #408). This will likely have to happen at some point as inputs are still being dropped when multiple at a time are used, as well as stuck in some scenarios, relevant issues at #374 and #105. This bug is still very annoying on my end at least so maybe something to shoot for in 0.9.3 / 0.9.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants