Add default dispose callback #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard complained about this.
|
Deploy request for elm-live pending review. Review with commit f45765d |
sparksp
force-pushed
the
fix-dispose-callback
branch
2 times, most recently
from
15a8b8a to
c48f712
Compare
I was seeing console errors due to a null `myDisposeCallback`. No where seems to be setting it, but `module.hot.apply` is still called. There should probably be some type checks that the callback is callable, but to keep the code clean I have provided a simple noop callback instead.
sparksp
force-pushed
the
fix-dispose-callback
branch
from
c48f712 to
f45765d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing console errors due to a null
myDisposeCallback. Nowhere seems to be callingmodule.hot.disposebutmodule.hot.applyis still called. There should probably be some type check that the callback is callable but to keep the code clean I have provided a simple noop callback instead.Here's the config that was failing for me: