Fix Publisher and skip signing where SHA2 unsupported

Signing service only supports signing with SHA2 so we can't sign VSIXs where VS does not support it (namely: VS2010, VS2012 VS2013).
wixtoolset · Jul 15, 2019 · d6fb0ad · d6fb0ad
1 parent 5d1f373
commit d6fb0ad
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 11 deletions.
diff --git a/src/Schemas/v3/source.extension.vsixmanifest b/src/Schemas/v3/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="WixToolset.VisualStudioExtension.Schemas3" Version="|v3schemas;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
+    <Identity Id="WixToolset.VisualStudioExtension.Schemas3" Version="|v3schemas;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
     <DisplayName>WiX Toolset v3 Schemas for Visual Studio</DisplayName>
     <Description>Visual Studio integraion for the WiX Toolset v3 schemas</Description>
     <MoreInfo>http://wixtoolset.org/</MoreInfo>

diff --git a/src/Schemas/v4/source.extension.vsixmanifest b/src/Schemas/v4/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="WixToolset.VisualStudioExtension.Schemas4" Version="|v4schemas;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
+    <Identity Id="WixToolset.VisualStudioExtension.Schemas4" Version="|v4schemas;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
     <DisplayName>WiX Toolset v4 Schemas for Visual Studio</DisplayName>
     <Description>Visual Studio integraion for the WiX Toolset v4 schemas</Description>
     <MoreInfo>http://wixtoolset.org/</MoreInfo>

diff --git a/src/Votive2010/Votive2010.csproj b/src/Votive2010/Votive2010.csproj
@@ -6,7 +6,8 @@
     <ProjectGuid>{3FFC5AB2-97CC-48C1-A28B-CC7F1CEEE92A}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AssemblyName>Votive2010</AssemblyName>
-    <ShouldSignOutput>true</ShouldSignOutput>
+    <!--- Signing only signs SHA2 and VS2010 does not support SHA2 so no signing -->
+    <ShouldSignOutput>false</ShouldSignOutput>
 
     <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
     <CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

diff --git a/src/Votive2010/source.extension.vsixmanifest b/src/Votive2010/source.extension.vsixmanifest
@@ -2,7 +2,7 @@
 <Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
   <Identifier Id="WixToolset.VisualStudioExtension.Dev10">
     <Name>Wix Toolset Visual Studio 2010 Extension</Name>
-    <Author>.NET Foundation and contributors</Author>
+    <Author>WiX Toolset</Author>
     <Version>|Votive2010;GetBuildVersion|</Version>
     <Locale>1033</Locale>
     <InstalledByMsi>false</InstalledByMsi>

diff --git a/src/Votive2012/Votive2012.csproj b/src/Votive2012/Votive2012.csproj
@@ -6,7 +6,8 @@
     <ProjectGuid>{40F7D778-7677-4597-AF84-C956A31A9EE9}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AssemblyName>Votive2012</AssemblyName>
-    <ShouldSignOutput>true</ShouldSignOutput>
+    <!--- Signing only signs SHA2 and VS2012 does not support SHA2 so no signing -->
+    <ShouldSignOutput>false</ShouldSignOutput>
 
     <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
     <CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

diff --git a/src/Votive2012/source.extension.vsixmanifest b/src/Votive2012/source.extension.vsixmanifest
@@ -2,7 +2,7 @@
 <Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
   <Identifier Id="WixToolset.VisualStudioExtension.Dev11">
     <Name>Wix Toolset Visual Studio 2012 Extension</Name>
-    <Author>.NET Foundation and contributors</Author>
+    <Author>WiX Toolset</Author>
     <Version>|Votive2012;GetBuildVersion|</Version>
     <Locale>1033</Locale>
     <InstalledByMsi>false</InstalledByMsi>

diff --git a/src/Votive2013/Votive2013.csproj b/src/Votive2013/Votive2013.csproj
@@ -6,7 +6,8 @@
     <ProjectGuid>{0877C6F6-73D9-46F1-89AB-43B6EC05EB9F}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AssemblyName>Votive2013</AssemblyName>
-    <ShouldSignOutput>true</ShouldSignOutput>
+    <!--- Signing only signs SHA2 and VS2013 does not support SHA2 so no signing -->
+    <ShouldSignOutput>false</ShouldSignOutput>
 
     <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
     <CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

diff --git a/src/Votive2013/source.extension.vsixmanifest b/src/Votive2013/source.extension.vsixmanifest
@@ -2,7 +2,7 @@
 <Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
   <Identifier Id="WixToolset.VisualStudioExtension.Dev12">
     <Name>Wix Toolset Visual Studio 2013 Extension</Name>
-    <Author>.NET Foundation and contributors</Author>
+    <Author>WiX Toolset</Author>
     <Version>|Votive2013;GetBuildVersion|</Version>
     <Locale>1033</Locale>
     <InstalledByMsi>false</InstalledByMsi>

diff --git a/src/Votive2015/source.extension.vsixmanifest b/src/Votive2015/source.extension.vsixmanifest
@@ -2,7 +2,7 @@
 <Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
   <Identifier Id="WixToolset.VisualStudioExtension.Dev14">
     <Name>Wix Toolset Visual Studio 2015 Extension</Name>
-    <Author>.NET Foundation and contributors</Author>
+    <Author>WiX Toolset</Author>
     <Version>|Votive2015;GetBuildVersion|</Version>
     <Locale>1033</Locale>
     <InstalledByMsi>false</InstalledByMsi>

diff --git a/src/Votive2017/source.extension.vsixmanifest b/src/Votive2017/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="WixToolset.VisualStudioExtension.Dev15" Version="|Votive2017;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
+    <Identity Id="WixToolset.VisualStudioExtension.Dev15" Version="|Votive2017;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
     <DisplayName>Wix Toolset Visual Studio 2017 Extension</DisplayName>
     <Description>Visual Studio integration for the WiX Toolset - the most powerful set of tools available to create your Windows installation experience.</Description>
     <MoreInfo>http://wixtoolset.org/</MoreInfo>

diff --git a/src/Votive2019/source.extension.vsixmanifest b/src/Votive2019/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="WixToolset.VisualStudioExtension.Dev16" Version="|Votive2019;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
+    <Identity Id="WixToolset.VisualStudioExtension.Dev16" Version="|Votive2019;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
     <DisplayName>Wix Toolset Visual Studio 2019 Extension</DisplayName>
     <Description>Visual Studio integration for the WiX Toolset - the most powerful set of tools available to create your Windows installation experience.</Description>
     <MoreInfo>http://wixtoolset.org/</MoreInfo>