Release #4
clippy
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.82.0 (f6e511eec 2024-10-15)
- cargo 1.82.0 (8f40fc59f 2024-08-21)
- clippy 0.1.82 (f6e511e 2024-10-15)
Annotations
Check warning on line 38 in src/endpoint/path.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
warning: this `let...else` may be rewritten with the `?` operator
--> src/endpoint/path.rs:36:9
|
36 | / let Some(up_resource_path) = self.up.resource_path() else {
37 | | return None;
38 | | };
| |__________^ help: replace it with: `let up_resource_path = self.up.resource_path()?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
Check warning on line 29 in src/crd/refs.rs
github-actions / clippy
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/crd/refs.rs:29:1
|
29 | impl Into<String> for RealmRef {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<crd::refs::RealmRef>`
|
29 ~ impl From<RealmRef> for String {
30 ~ fn from(val: RealmRef) -> Self {
31 ~ val.realm_ref
|
Check warning on line 19 in src/crd/refs.rs
github-actions / clippy
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/crd/refs.rs:19:1
|
19 | impl Into<String> for ClientScopeRef {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
help: replace the `Into` implementation with `From<crd::refs::ClientScopeRef>`
|
19 ~ impl From<ClientScopeRef> for String {
20 ~ fn from(val: ClientScopeRef) -> Self {
21 ~ val.client_scope_ref
|
Check warning on line 9 in src/crd/refs.rs
github-actions / clippy
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/crd/refs.rs:9:1
|
9 | impl Into<String> for ClientRef {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<crd::refs::ClientRef>`
|
9 ~ impl From<ClientRef> for String {
10~ fn from(val: ClientRef) -> Self {
11~ val.client_ref
|
Check warning on line 134 in src/controller/api_object_controller.rs
github-actions / clippy
redundant pattern matching, consider using `is_some()`
warning: redundant pattern matching, consider using `is_some()`
--> src/controller/api_object_controller.rs:134:20
|
134 | if let Some(_) =
| _____________- ^^^^^^^
135 | | self.request(&keycloak, Method::PUT, path, &payload).await?
| |___________________________________________________________________________- help: try: `if (self.request(&keycloak, Method::PUT, path, &payload).await?).is_some()`
|
= note: this will change drop order of the result, as well as all temporaries
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default