clippy

src/controller/api_object_controller.rs

@@ -131,8 +131,10 @@ impl LifecycleController for KeycloakApiObjectController {
             .as_ref()
             .and_then(|x| x.resource_path.as_ref())
         {
-            if let Some(_) =
-                self.request(&keycloak, Method::PUT, path, &payload).await?
+            if self
+                .request(&keycloak, Method::PUT, path, &payload)
+                .await?
+                .is_some()
             {
                 success = true;
                 api.patch_status(

src/crd/refs.rs

@@ -6,28 +6,28 @@ use serde::{Deserialize, Serialize};
 pub struct ClientRef {
     pub client_ref: String,
 }
-impl Into<String> for ClientRef {
-    fn into(self) -> String {
-        self.client_ref
+impl From<ClientRef> for String {
+    fn from(val: ClientRef) -> Self {
+        val.client_ref
     }
 }
 #[derive(Clone, Debug, Deserialize, Serialize, JsonSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct ClientScopeRef {
     pub client_scope_ref: String,
 }
-impl Into<String> for ClientScopeRef {
-    fn into(self) -> String {
-        self.client_scope_ref
+impl From<ClientScopeRef> for String {
+    fn from(val: ClientScopeRef) -> Self {
+        val.client_scope_ref
     }
 }
 #[derive(Clone, Debug, Deserialize, Serialize, JsonSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct RealmRef {
     pub realm_ref: String,
 }
-impl Into<String> for RealmRef {
-    fn into(self) -> String {
-        self.realm_ref
+impl From<RealmRef> for String {
+    fn from(val: RealmRef) -> Self {
+        val.realm_ref
     }
 }

src/endpoint/path.rs

@@ -33,9 +33,7 @@ where
     }
 
     fn endpoint_path(&self) -> Option<String> {
-        let Some(up_resource_path) = self.up.resource_path() else {
-            return None;
-        };
+        let up_resource_path = self.up.resource_path()?;
         Some(format!("{}/{}", up_resource_path, self.value.mount_point()))
     }