Skip to content

add missing changes #82

add missing changes

add missing changes #82

Triggered via push September 18, 2023 19:36
Status Failure
Total duration 5m 36s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

check.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 20 warnings
check-mac
The process '/Users/runner/.cargo/bin/cargo' failed with exit code 101
useless conversion to the same type: `std::env::VarsOs`: src/toolbox/tool.rs#L302
warning: useless conversion to the same type: `std::env::VarsOs` --> src/toolbox/tool.rs:302:23 | 302 | let new_env = env::vars_os() | _______________________^ 303 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `env::vars_os()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
the borrowed expression implements the required traits: src/toolbox/tool.rs#L281
warning: the borrowed expression implements the required traits --> src/toolbox/tool.rs:281:40 | 281 | let mut command = Command::new(&bin); | ^^^^ help: change this to: `bin` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of `.unwrap_or_else(..)` to construct default value: src/completion/zsh.rs#L697
warning: use of `.unwrap_or_else(..)` to construct default value --> src/completion/zsh.rs:697:17 | 697 | value_completion(arg).unwrap_or_else(|| "".to_string()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value_completion(arg).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_else_default = note: `#[warn(clippy::unwrap_or_else_default)]` on by default
dereferencing a tuple pattern where every element takes a reference: src/completion/zsh.rs#L254
warning: dereferencing a tuple pattern where every element takes a reference --> src/completion/zsh.rs:254:9 | 254 | for &(ref name, ref bin_name) in &subcommand_names { | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference help: try removing the `&` and `ref` parts | 254 - for &(ref name, ref bin_name) in &subcommand_names { 254 + for (name, bin_name) in &subcommand_names { |
dereferencing a tuple pattern where every element takes a reference: src/completion/zsh.rs#L136
warning: dereferencing a tuple pattern where every element takes a reference --> src/completion/zsh.rs:136:9 | 136 | for &(_, ref bin_name) in &all_subcommands { | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `#[warn(clippy::needless_borrowed_reference)]` on by default help: try removing the `&` and `ref` parts | 136 - for &(_, ref bin_name) in &all_subcommands { 136 + for (_, bin_name) in &all_subcommands { |
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-lin
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check-lin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-lin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-lin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-lin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-mac
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check-mac
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-mac
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-mac
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-mac
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/