Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rich text editor v2 [WPB-12089] #18528

Merged
merged 6 commits into from
Dec 18, 2024
Merged

fix: rich text editor v2 [WPB-12089] #18528

merged 6 commits into from
Dec 18, 2024

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Dec 18, 2024

StoryWPB-12089 [Web] Text formatting via UI in text input field

Description

Continuation of #18520

What's changed?

  • fix mentions (before it was breaking with the | character and multiple same mentions next to each other)
  • remove unnecessary line spacing (white-space: pre-wrap;)
  • fix edit message view (rich text turned off)

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.15%. Comparing base (aec9c85) to head (336007b).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18528   +/-   ##
=======================================
  Coverage   46.15%   46.15%           
=======================================
  Files         865      865           
  Lines       26654    26654           
  Branches     6033     6033           
=======================================
  Hits        12303    12303           
  Misses      12812    12812           
  Partials     1539     1539           

@olafsulich olafsulich marked this pull request as ready for review December 18, 2024 12:55
@olafsulich olafsulich requested review from otto-the-bot and a team as code owners December 18, 2024 12:55
@olafsulich olafsulich merged commit 4cdae2b into dev Dec 18, 2024
11 checks passed
@olafsulich olafsulich deleted the fix/rich-text-editor-v2 branch December 18, 2024 13:17
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants