-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update Manager Refactor #1259
Draft
jaxwilko
wants to merge
14
commits into
wip/support-uploading-packages
Choose a base branch
from
wip/support-uploading-packages-update-manager-changes
base: wip/support-uploading-packages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Update Manager Refactor #1259
jaxwilko
wants to merge
14
commits into
wip/support-uploading-packages
from
wip/support-uploading-packages-update-manager-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and Luke are working on a little refactor of how the UpdateManager works...
It also includes some components from my old composer PR found here: #967
The core idea of this is that there should be consistent interfaces to interact with different things built on top of Winter (i.e.
modules
,plugins
&themes
). Each of these elements will now have their class (i.e.Theme
,PluginBase
,ModuleServiceProvider
) will now extendWinterExtension
which will allow them to all interact with the update manager and other system functions directly.In addition
PluginManager
,ThemeManager
&ModuleManager
(new) will all implement theExtensionManager
interface, which will allow for a consistant way to interact with all Winter extensions.I.e. You will be able to call
PluginManager::instance()->update($plugin)
orThemeManager::instance()->update($theme)
.This also allows us to do some cool stuff like (only support for plugin installing is currently functional)
By the end of the PR, the UpdateManager as is may no longer exist as is, instead each
ExtensionManager
will be responsible for it's existing functionality.Requires storm branch: https://github.com/wintercms/storm/tree/wip/support-uploading-packages-update-manager-changes