Skip to content

Commit

Permalink
Fix handling of booleans that are actually strings
Browse files Browse the repository at this point in the history
  • Loading branch information
wilkinsona committed May 10, 2024
1 parent 101b3a5 commit 6c1962f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ inputs:
outputs:
build-scan-url:
description: 'The URL, if any, of the build scan produced by the build'
value: ${{ (inputs.publish && steps.build-and-publish.outputs.build-scan-url) || steps.build.outputs.build-scan-url }}
value: ${{ (inputs.publish == 'true' && steps.build-and-publish.outputs.build-scan-url) || steps.build.outputs.build-scan-url }}
version:
description: 'The version that was built'
value: ${{ steps.read-version.outputs.version }}
Expand All @@ -33,14 +33,14 @@ runs:
java-toolchain: ${{ inputs.java-toolchain }}
- name: Build
id: build
if: ${{ !inputs.publish }}
if: ${{ inputs.publish == 'false' }}
shell: bash
env:
DEVELOCITY_ACCESS_KEY: ${{ inputs.develocity-access-key }}
run: ./gradlew build
- name: Build and Publish
id: build-and-publish
if: ${{ inputs.publish }}
if: ${{ inputs.publish == 'true' }}
shell: bash
env:
DEVELOCITY_ACCESS_KEY: ${{ inputs.develocity-access-key }}
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/prepare-gradle-build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
distribution: 'liberica'
java-version: |
${{ inputs.java-version }}
${{ inputs.java-toolchain && '17' || '' }}
${{ inputs.java-toolchain == 'true' && '17' || '' }}
- name: Set Up Gradle
uses: gradle/actions/setup-gradle@db19848a5fa7950289d3668fb053140cf3028d43 # v3.3.2
with:
Expand All @@ -31,7 +31,7 @@ runs:
echo 'systemProp.org.gradle.internal.launcher.welcomeMessageEnabled=false' >> $HOME/.gradle/gradle.properties
echo 'org.gradle.daemon=false' >> $HOME/.gradle/gradle.properties
- name: Configure Toolchain Properties
if: ${{ inputs.java-toolchain }}
if: ${{ inputs.java-toolchain == 'true' }}
shell: bash
run: |
echo toolchainVersion=${{ inputs.java-version }} >> $HOME/.gradle/gradle.properties
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/publish-to-sdkman/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runs:
-d '{"candidate": "springboot", "version": "${{ inputs.spring-boot-version }}", "url": "${{ format('https://repo.maven.apache.org/maven2/org/springframework/boot/spring-boot-cli/{0}/spring-boot-cli-{0}-bin.zip', inputs.spring-boot-version) }}"}' \
https://vendors.sdkman.io/release
- shell: bash
if: ${{ inputs.make-default }}
if: ${{ inputs.make-default == 'true' }}
run: >
curl -X POST \
-H "Consumer-Key: ${{ inputs.sdkman-consumer-key }}" \
Expand Down

0 comments on commit 6c1962f

Please sign in to comment.