Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-19356] jsonp Quickstarts should have a root webpage similar to helloworld #917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WFLY-19356] jsonp Quickstarts should have a root webpage similar to helloworld #917

wants to merge 1 commit into from

Conversation

sudeshnas93
Copy link
Contributor

@sudeshnas93 sudeshnas93 requested a review from emmartins as a code owner May 22, 2024 11:58
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2024

Hi @sudeshnas93. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

iweiss
iweiss reviewed May 28, 2024
View reviewed changes
jsonp/src/main/webapp/index.html Outdated

<h1>Hello There! Welcome to WildFly!</h1>
<h2>The jsonp application has been deployed and running successfully.</h2>
<a href="http://localhost:8080/jsonp/jsonp.jsf" title="Go to JSONP Form">Access the jsonp application here</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the href can be just jsonp.jsf since customers can use different host names and ports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iweiss iweiss iweiss left review comments

@emmartins emmartins Awaiting requested review from emmartins emmartins is a code owner

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudeshnas93 @iweiss