Added contestant number (order) for WSContest contest page #70
Conversation
|
Hello, @samwilson will you please review this commit and provide me feedback for the same. |
| @@ -55,6 +55,7 @@ | |||
| <caption style="caption-side: top">{{ msg('scores-legend', [score_calculation_interval~'']) }}</caption> | |||
| <thead> | |||
| <tr> | |||
| <th>{{ msg('rank') }}</th> | |||
There was a problem hiding this comment.
The rank message needs to be added to i18n/en.json and i18n/qqq.json.
There was a problem hiding this comment.
Okay I got your point, submitting the updated patch very soon! Thanks for your guidance.
No, I'm not having any issues when testing locally; I just assumed it was a minor edit and so didn't checked it thoroughly. |
Okay, no worries. It looks like you've created #73 as a replacement for this PR, is that right? Let's close this one and continue the discussion over there. (In general, you don't need to create separate PRs for fixing review issues, you can just push more commits to the branch here.) |
I have added contestant number (order) for WSContest contest page. It will be beneficial to the contestant as well as admins to be able to tell, for example: who are the top 10 contestant, how many total contestants are there, etc.