-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Changes in 0.4.0: Removed Namespace Management and ServiceAccount, Fixed LangKit API Secret Documentation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnchorArray
commented
Jan 26, 2024
- Only publish on merge to main; Added a template output step to view what the manifest files generated by the charts
- Added macos artifact to ignore
- Updated documentation example to reflect changes made to langkit (which is used in the example)
- Added documentation for specifying volumes; updated documentation; removed namespace management; fixed secret key reference; removed serviceaccount
…hat the manifest files generated by the charts
…ch is used in the example)
…moved namespace management; fixed secret key reference; removed serviceaccount
AnchorArray
changed the title
dev/aberg/add directory configuration
Breaking Changes in 0.4.0: Removed Namespace Management and ServiceAccount, Fixed LangKit API Secret Documentation
Jan 26, 2024
Cosmetic restructure
…umes to paths that must be writable
…ylabs/charts into dev/aberg/add-directory-configuration
andyndang
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.