Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector label incompatibility #39

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

AnchorArray
Copy link
Contributor

@AnchorArray AnchorArray commented Dec 9, 2024

Guardrails 0.3.0 Deployment:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: guardrails
  labels:
    helm.sh/chart: guardrails-0.3.0
    app.kubernetes.io/name: guardrails
    app.kubernetes.io/instance: guardrails
    app.kubernetes.io/version: "2.0.1"
    app.kubernetes.io/managed-by: Helm
spec:
  revisionHistoryLimit: 1
  replicas: 4
  selector:
    matchLabels:
      app.kubernetes.io/name: guardrails                 # The selector labels used by 0.3.0 version of the chart (immutable)
      app.kubernetes.io/instance: guardrails
  template:
    metadata:
      labels:
        helm.sh/chart: guardrails-0.3.0
        app.kubernetes.io/name: guardrails
        app.kubernetes.io/instance: guardrails
        app.kubernetes.io/version: "2.0.1"
        app.kubernetes.io/managed-by: Helm

Guardrails 0.5.0 Deployment

apiVersion: apps/v1
kind: Deployment
metadata:
  name: guardrails
  labels:
    helm.sh/chart: guardrails-0.5.0
    app.kubernetes.io/version: "2.2.2"
    app.kubernetes.io/managed-by: Helm
spec:
  revisionHistoryLimit: 1
  replicas: 4
  selector:
    matchLabels:
      app: guardrails            # Changing to this label from the 0.3.0 configuration requires recreating the deployment
  template:
    metadata:
      labels:
        helm.sh/chart: guardrails-0.5.0
        app.kubernetes.io/version: "2.2.2"
        app.kubernetes.io/managed-by: Helm
        app: guardrails
        app.kubernetes.io/name: guardrails
        app.kubernetes.io/instance: guardrails

Guardrails 0.5.1 Deployment

apiVersion: apps/v1
kind: Deployment
metadata:
  name: guardrails
  labels:
    helm.sh/chart: guardrails-0.5.1
    app.kubernetes.io/version: "2.2.2"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: guardrails
    app.kubernetes.io/instance: guardrails
spec:
  revisionHistoryLimit: 1
  replicas: 4
  selector:
    matchLabels:
      app.kubernetes.io/name: guardrails           # Reverted change and handled cache deployment labels separately
      app.kubernetes.io/instance: guardrails
  template:
    metadata:
      labels:
        helm.sh/chart: guardrails-0.5.1
        app.kubernetes.io/version: "2.2.2"
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/name: guardrails
        app.kubernetes.io/instance: guardrails

@AnchorArray AnchorArray self-assigned this Dec 9, 2024
@AnchorArray AnchorArray merged commit 4cb9a3b into mainline Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant