Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image pull secret prefix to be scoped to service rather than organization #16

Merged
merged 2 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/langkit/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning]
(https://semver.org/spec/v2.0.0.html).

## [0.13.1] - 2023-03-01

### Changed

- Change `imagePullSecret` name to be scoped to service

## [0.13.0] - 2023-02-29

### Changed
Expand Down
2 changes: 1 addition & 1 deletion charts/langkit/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: langkit
description: A Helm chart for LangKit container deployment
type: application
version: 0.13.0
version: 0.13.1
appVersion: "1.0.8"
6 changes: 3 additions & 3 deletions charts/langkit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ kubectl create secret generic langkit-api-secret \
* Create a secret with a WhyLabs provided GitLab token to pull the LangKit image

```
kubectl create secret docker-registry whylabs-gitlab-registry-secret \
--docker-server=registry.gitlab.com \
kubectl create secret docker-registry langkit-gitlab-registry-secret \
--docker-server="registry.gitlab.com" \
--docker-username="project_55361491_bot_4a4030bd91182991f959fe2a3cdd2762" \
--docker-password="<token>" \
--docker-email="project_55361491_bot_4a4030bd91182991f959fe2a3cdd2762@noreply.gitlab.com" \
Expand Down Expand Up @@ -110,7 +110,7 @@ helm-docs --dry-run
| image.pullPolicy | string | `"Always"` | |
| image.repository | string | `"registry.gitlab.com/whylabs/langkit-container"` | |
| image.tag | string | `"1.0.8"` | |
| imagePullSecrets[0].name | string | `"whylabs-gitlab-registry-secret"` | |
| imagePullSecrets[0].name | string | `"langkit-gitlab-registry-secret"` | |
| ingress.annotations | object | `{}` | |
| ingress.className | string | `""` | |
| ingress.enabled | bool | `false` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/langkit/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ image:
containerPort: 8000

imagePullSecrets:
- name: whylabs-gitlab-registry-secret
- name: langkit-gitlab-registry-secret

pod:
annotations: {}
Expand Down
Loading