Merge pull request #16 from whylabs/dev/aberg/pull-image-name-#86azhrbm9

Change image pull secret prefix to be scoped to service rather than organization
whylabs · Mar 1, 2024 · c25ae35 · c25ae35
2 parents 6741c83 + a249885
commit c25ae35
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/charts/langkit/CHANGELOG.md b/charts/langkit/CHANGELOG.md
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning]
 (https://semver.org/spec/v2.0.0.html).
 
+## [0.13.1] - 2023-03-01
+
+### Changed
+
+- Change `imagePullSecret` name to be scoped to service
+
 ## [0.13.0] - 2023-02-29
 
 ### Changed

diff --git a/charts/langkit/Chart.yaml b/charts/langkit/Chart.yaml
@@ -2,5 +2,5 @@ apiVersion: v2
 name: langkit
 description: A Helm chart for LangKit container deployment
 type: application
-version: 0.13.0
+version: 0.13.1
 appVersion: "1.0.8"
diff --git a/charts/langkit/README.md b/charts/langkit/README.md
@@ -33,8 +33,8 @@ kubectl create secret generic langkit-api-secret \
 * Create a secret with a WhyLabs provided GitLab token to pull the LangKit image
 
 ```
-kubectl create secret docker-registry whylabs-gitlab-registry-secret \
-  --docker-server=registry.gitlab.com \
+kubectl create secret docker-registry langkit-gitlab-registry-secret \
+  --docker-server="registry.gitlab.com" \
   --docker-username="project_55361491_bot_4a4030bd91182991f959fe2a3cdd2762" \
   --docker-password="<token>" \
   --docker-email="project_55361491_bot_4a4030bd91182991f959fe2a3cdd2762@noreply.gitlab.com" \
@@ -110,7 +110,7 @@ helm-docs --dry-run
 | image.pullPolicy | string | `"Always"` |  |
 | image.repository | string | `"registry.gitlab.com/whylabs/langkit-container"` |  |
 | image.tag | string | `"1.0.8"` |  |
-| imagePullSecrets[0].name | string | `"whylabs-gitlab-registry-secret"` |  |
+| imagePullSecrets[0].name | string | `"langkit-gitlab-registry-secret"` |  |
 | ingress.annotations | object | `{}` |  |
 | ingress.className | string | `""` |  |
 | ingress.enabled | bool | `false` |  |

diff --git a/charts/langkit/values.yaml b/charts/langkit/values.yaml
@@ -35,7 +35,7 @@ image:
   containerPort: 8000
 
 imagePullSecrets:
-  - name: whylabs-gitlab-registry-secret
+  - name: langkit-gitlab-registry-secret
 
 pod:
   annotations: {}