Use CommonMark in convert-policy.py #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few subtle issues and is a pre-requisite for fixing more.
|
whatwg/sg#104 should probably land first. The commits in #294 can be used to review the effect of this. I ended up cleaning up the code a bit further compared to that, but I promise there's no difference in output. |
This was referenced Mar 7, 2020
|
This should close #291 as well. |
domenic
reviewed
Mar 9, 2020
|
Feedback addressed. |
domenic
approved these changes
Mar 9, 2020
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few subtle issues and is a prerequisite for fixing more.