Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloning for maps #265

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Add cloning for maps #265

merged 2 commits into from
Aug 30, 2019

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 29, 2019 •
edited by pr-preview bot
Loading

A need for this came up in WICG/import-maps#167

Preview | Diff

@domenic domenic requested a review from annevk August 29, 2019 20:35
@domenic domenic mentioned this pull request Aug 29, 2019
Open
annevk
annevk approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo nits, looks good.

infra.bs Outdated Show resolved Hide resolved
infra.bs Outdated Show resolved Hide resolved
@domenic domenic merged commit d109ae2 into master Aug 30, 2019
@annevk annevk deleted the clone-map branch August 30, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk