feat: 마이페이지 ui 제작 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaei623
reviewed
Sep 17, 2023
| </Row> | ||
| <Typo.s1 color={Palette.Main}>D-6</Typo.s1> | ||
| <Typo.s1 color={Palette.Main}>D-{dDay}</Typo.s1> |
There was a problem hiding this comment.
답변 완료된 질문은 d-day 안보이게 수정해주세요!
src/assets/common.ts
Outdated
| @@ -1,6 +1,21 @@ | |||
| import { styled } from 'styled-components'; | |||
| import { Palette } from 'styles/Palette'; | |||
|
|
|||
| export const EntireContainer = styled.div` | |||
There was a problem hiding this comment.
'내댓글'이 4개만 있는데 배경색이 딱 그만큼만 바뀌고 있어서 EntireContainer는 height를 100%로 넣어야 할 거 같아요
| 운영하는 Website 또는 Application 등 온라인 쇼핑 플랫폼 서비스와 | ||
| 관련하여, 회사와 서비스를 이용하는 자(이하 “이용자”라 합니다) | ||
| 사이의 권리, 의무, 기타 필요한 사항을 정함으로써 상호 이익을 | ||
| 도모하는 것을 그 목적으로 합니다. 제 2 조 [용어의 정의] ① 이 |
There was a problem hiding this comment.
중간에 제 2조가 글에 섞여 들어갔는데ㅎㅎ 이건 나중에 텍스트 보기 편하게 정리하면 될 거 같습니다
src/pages/Mypage/index.tsx
Outdated
| <Typo.h4> 님</Typo.h4> | ||
| </UnderLine> | ||
| </Column> | ||
| <img src="/img/juniIcon.svg" /> |
There was a problem hiding this comment.
cyniIcon이 오는 경우도 추가해야될 거 같습니다
| ); | ||
| }; | ||
|
|
||
| const StyledLink = styled(Link)<{ margin?: number }>` |
There was a problem hiding this comment.
그동안 그냥 link로 더럽게 썼었는데,, styledlink 너무 좋은 방법인거 같아요ㅎㅎ 아예 common 스타일로 빼서 쓰는거 어떤가요?
src/pages/Mypage/MyQna/index.tsx
Outdated
| <Typo.b2>{text} </Typo.b2> | ||
| <Typo.b2 color={Palette.Main}>12</Typo.b2> | ||
| </Row> | ||
| {nowTab === 1 ? ( |
There was a problem hiding this comment.
삼항연산자 대신 && 연산자 쓰면 코드가 더 간단해질 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
#4
수정사항
기타