Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write test codes of GoalGifticonController #93

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Write test codes of GoalGifticonController #93

merged 5 commits into from
Apr 22, 2024

Conversation

mkSpace
Copy link
Collaborator

@mkSpace mkSpace commented Apr 22, 2024 •
edited
Loading

다음 수정사항이 있습니다.

  • 간편한 테스트를 위해 extension 함수를 ControllerTestSupport에 추가하였습니다.
  • GoalGifticonController 에서 Request를 RequestBody로 받지 않던 이슈를 해결했습니다.
  • GoalGifticonController 에서 HttpStatus.CREATED로 잘못 응답하던 이슈를 해결했습니다.
  • GoalGifticonControllerTest를 작성했습니다.
  • 코틀린에서 RequestBody로 받는 Request DTO에 @field:NotNull은 val로 데이터 타입을 정의한 순간 의미가 없는 코드이기에 불필요한 코드를 삭제했습니다.

@mkSpace mkSpace requested a review from K-Diger April 22, 2024 09:48
@K-Diger K-Diger added the enhancement New feature or request label Apr 22, 2024
K-Diger
K-Diger approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@K-Diger K-Diger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 잘하시네요... 고생하셨습니다 ^^7

@mkSpace mkSpace merged commit f680709 into develop Apr 22, 2024
1 check passed
@mkSpace mkSpace deleted the feature/goal-gifticon-controller-test branch April 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Diger K-Diger K-Diger approved these changes

Assignees

@mkSpace mkSpace

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkSpace @K-Diger