다짐 생성 컨트롤러에서 user를 가져오는 방식을 변경합니다. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mkSpace
reviewed
Dec 9, 2023
| presignedURL: String | ||
| ): Goal { | ||
| val user = userService.loadById(userInfo.id) |
There was a problem hiding this comment.
userId만 받아도될듯해요 Request와 마찬가지로 굳이 안끌고 내려가도 될듯? 큰 차이는 없지만
mkSpace
approved these changes
Dec 9, 2023
K-Diger
force-pushed
the
refactor/make-goal
branch
from
5c42b6d to
a821541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
다짐 생성 컨트롤러에서 user를 가져오는 방식을 변경합니다.
#19 에 의한 AOP방식으로 유저를 가져오기위해
기존 user: User -> userInfo: UserInfo방식으로 유저를 가져오는 방식으로 변경합니다.
#20 가 병합된 후 머지되어야합니다.