Implement JwtAgent, Kakao Login #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkSpace
reviewed
Dec 8, 2023
| fun verifyKakao(userToken: String): String? | ||
| fun verifyKaKao(accessToken: String): String |
There was a problem hiding this comment.
약간 워딩을 accessToken 말고 SNS임을 분명하게 해주면 좋을 것 같아요
There was a problem hiding this comment.
딱히 좋은 네이밍이 생각이 안나서 원상복구 해둘게염
|
|
||
| private fun buildClaims(user: User): Claims { | ||
| val claims = Jwts.claims() | ||
| claims.setSubject(user.nickname.nickname) |
There was a problem hiding this comment.
아.. nickname.nickname은 좀 구린데 이거 Wrapper면 일괄적으로 value라고 하는건 어때요?
| KakaoLoginResponse::class.java | ||
| ) | ||
|
|
||
| return response.body!!.id!! |
There was a problem hiding this comment.
Suggested change
| return response.body!!.id!! | |
| return response.body?.id!! |
이렇게는 안되나요? 일단 id를 못받아오는경우 예외가 터질텐데 괜찮은가요?
There was a problem hiding this comment.
못받아올때의 에러처리를 따로 해봐야겠네요
| @@ -6,5 +6,17 @@ import org.springframework.transaction.annotation.Transactional | |||
| @Service | |||
| @Transactional | |||
There was a problem hiding this comment.
보통 여기서 readOnly = true 하고 밑에 실제 트랜잭션 동작이 있는곳에 @transactional 붙이지 않나요? readOnly의 default가 true인것 같아서요
There was a problem hiding this comment.
저는 default가 false로 알고있는데 이건 그냥 저희끼리만 통일화하면 될 것 같아요~
Comment on lines
15
to
16
| return user.toDto() |
There was a problem hiding this comment.
Suggested change
| val user = userRepository.findByOauthTokenPayload(payload) ?: return null | |
| return user.toDto() | |
| return userRepository.findByOauthTokenPayload(payload)?.toDto() |
K-Diger
force-pushed
the
feature/oauth2
branch
from
b6f175f to
b22eba5
Compare
K-Diger
force-pushed
the
feature/oauth2
branch
from
26d9a31 to
6256054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가사항 1. JwtAgent를 구현
프로젝트 전역으로 사용할 JWTAgent를 구현했습니다.
추가사항 2. KakaoOauth 구현
카카오 로그인 기능을 추가했습니다. 클라이언트로부터 AccessToken을 전달받도록 하였습니다.
++ Local DB에 대한 비밀번호가 달라 Jasypt를 다시 재민님 환경에 맞게 수정해주셔야할 것 같네요 ㅠ