Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lustre changelog user stats output #47

Merged
merged 1 commit into from
May 8, 2024

Conversation

breuhan
Copy link
Contributor

@breuhan breuhan commented Apr 23, 2024

This PR includes functionality to query and report on the status of changelog users for each MDT.
This will provide a more granular insight into the changelog processing performance.

The output format is as follows:

mds# lctl get_param mdd.lustre-MDT0000.changelog_users
mdd.lustre-MDT0000.changelog_users=current index: 8
ID    index (idle seconds)
cl2   8 (180)

This depends on whamcloud/lustre-collector#66

@breuhan breuhan added the enhancement New feature or request label Apr 23, 2024
@breuhan breuhan self-assigned this Apr 23, 2024
@breuhan breuhan force-pushed the breuhan/display_changelog_stats branch from 15474f7 to 44493ef Compare April 23, 2024 06:57
@breuhan
Copy link
Contributor Author

breuhan commented Apr 24, 2024

This depends on whamcloud/lustre-collector#66

@jgrund jgrund requested review from a team, utopiabound and palash3 and removed request for a team April 30, 2024 15:01
Copy link
Contributor

@utopiabound utopiabound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch seems fine. I think the commit message itself should be more along the lines of:

EX-nnnn component: short subject line

Longer description of change, and why

Signed-off-by: you name <[email protected]>

This more closely adheres to Lustre Commit message format.

@breuhan
Copy link
Contributor Author

breuhan commented May 8, 2024

The patch seems fine. I think the commit message itself should be more along the lines of:

EX-nnnn component: short subject line

Longer description of change, and why

Signed-off-by: you name <[email protected]>

This more closely adheres to Lustre Commit message format.

We decided against this, because this is a public repository.
But I will update the PR description.

@breuhan breuhan requested a review from jgrund May 8, 2024 07:33
@jgrund jgrund force-pushed the breuhan/display_changelog_stats branch from 53daee7 to 117df22 Compare May 8, 2024 14:26
@jgrund
Copy link
Member

jgrund commented May 8, 2024

A number of CI issues in this one.

@breuhan
Copy link
Contributor Author

breuhan commented May 8, 2024

A number of CI issues in this one.

Yes, they will get resolved when whamcloud/lustre-collector#66 is merged

@jgrund jgrund force-pushed the breuhan/display_changelog_stats branch from 117df22 to e3b0ee6 Compare May 8, 2024 20:48
@jgrund jgrund force-pushed the breuhan/display_changelog_stats branch from e3b0ee6 to 6423722 Compare May 8, 2024 20:51
@jgrund jgrund requested a review from utopiabound May 8, 2024 20:52
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (3757bad) to head (6423722).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   90.93%   91.42%   +0.48%     
==========================================
  Files           8        8              
  Lines         993     1038      +45     
  Branches      993     1038      +45     
==========================================
+ Hits          903      949      +46     
+ Misses         82       81       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgrund jgrund merged commit 094f7aa into main May 8, 2024
12 checks passed
@jgrund jgrund deleted the breuhan/display_changelog_stats branch May 8, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants