Cleanup warnings #600
Merged
Cleanup warnings #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yy_state_buf_max and yyread's max_size are both (yy_)size_t so ensure the comparison is against (yy_)size_t for the other expression.
This prevents unused variable warnings in lexers that don't use reject.
yy_create_buffer makes no use of YY_G and thus does not require its declaration. Removes another unused variable warning.
The declaration had the ifdef, but the defintion was missing it, thus lexers that don't use yyunput would generate an unused static function warning.
It turns out I had missed some tests for recursive scanners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the warnings encountered when trying to build QuakeForge with the git version of flex.