Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filter rules reloading #605

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Improve filter rules reloading #605

merged 4 commits into from
Dec 18, 2024

Conversation

newborn22
Copy link
Collaborator

Related Issue(s) & Descriptions

#596

  1. Load the existing rules from the system table as soon as the filter component starts.
  2. Change the filter's create, drop, and alter processes from asynchronous to synchronous.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@newborn22 newborn22 requested a review from earayu December 17, 2024 13:23
earayu
earayu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@earayu earayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earayu earayu merged commit 5336f06 into main Dec 18, 2024
22 checks passed
@earayu earayu deleted the improve_filter_rules_reloading branch December 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earayu earayu earayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newborn22 @earayu