Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:onlineDDL controller and engine with dbName #308

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

gerayking
Copy link
Contributor

Description

Removed the strong binding between Engine and dbName in vreplication, allowing dbName to be bound to each onlineDDL task.

@gerayking gerayking added this to the OnlineDDL milestone Oct 8, 2023
@gerayking gerayking requested a review from earayu October 8, 2023 08:53
@gerayking gerayking marked this pull request as draft October 8, 2023 08:53
@gerayking gerayking force-pushed the onlineDDL/fix_engine_controller_dbName branch from ae853e4 to c69513d Compare October 9, 2023 09:45
@gerayking gerayking changed the base branch from main to bugfix/fix-testSelectLock-testcase October 9, 2023 09:53
@gerayking gerayking changed the base branch from bugfix/fix-testSelectLock-testcase to main October 9, 2023 09:53
@gerayking gerayking self-assigned this Oct 11, 2023
@earayu earayu marked this pull request as ready for review October 11, 2023 08:26
Copy link
Collaborator

@earayu earayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerayking gerayking merged commit 4f551cf into main Oct 11, 2023
5 checks passed
@gerayking gerayking deleted the onlineDDL/fix_engine_controller_dbName branch October 11, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants