remove RaftNode construct code to init #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenweihu86
reviewed
Nov 11, 2018
| @@ -0,0 +1,13 @@ | |||
| package com.github.wenweihu86.raft; | |||
|
|
|||
| public class PeerId { | |||
There was a problem hiding this comment.
PeerId作为map的key时，应该实现equals和hashcode函数。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
感觉冗余代码有点多。。。
这里把构造函数中的代码放到init中，同时禁止init被调用两次
去掉peerMap的get方法，外界不应该接触到peerMap