testing #2
Open
testing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the page build task is ongoing, the progress bar shown is interrupted unexpectedly by warnings or error logs, which will be written to the console without any preceding linebreak. Let's patch the node-progress package to signal the start and the end of a proper interruption, and have the loggers invoke these methods before and after logging. Let's also upgrade the logger dependencies. When the progress bar is running, the loggers will call the relevant method to clear off the current bar before logging and redraws the progress bar afterward.
Since no assumptions of the user's header's height can be made at build time, runtime style detection is required to calculate the header height used in the fixed-header-padding class. This causes a flash of unstyled content briefly before this detection is done (the content is hidden behind the header). Let's implement a sticky header instead, which "natively" offsets content below it. It should be noted that header height detection is still required however, particularly for offsetting the sticky positioning of the navigation menus on the side (top: var(--sticky-header-height)), since they are (usually) much shorter than the main content element. This header height is now exposed using the css variable var(--sticky-header-height) for use in the user layout files.
Adjust the about-us page to read all-contributors info
- All embeds save for ppt are scaled to 100% container width - Ppt embeds are kept as is for usability (see PR discussion)
Improve Dev Guide's merge PR section
* Remove seg tag from includes.md * Remove seg tag from tests * Fix div tag in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️